Skip to content

Commit 90bcd22

Browse files
committed
fix: release static ui workflow incorrectly accesses github secrets
Signed-off-by: Nick Mitchell <[email protected]>
1 parent 7fad845 commit 90bcd22

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

.github/workflows/release-static-web-app.yml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,6 @@ jobs:
2525
with:
2626
node-version: lts/*
2727

28-
# - name: install Rust stable
29-
# uses: dtolnay/rust-toolchain@stable
30-
# with:
31-
# # Those targets are only used on macos runners so it's in an `if` to slightly speed up windows and linux builds.
32-
# targets: ${{ matrix.platform == 'macos-latest' && 'aarch64-apple-darwin,x86_64-apple-darwin' || '' }}
33-
3428
- name: install dependencies (ubuntu only)
3529
run: |
3630
sudo apt-get update
@@ -39,8 +33,12 @@ jobs:
3933
chmod +x mc
4034
sudo mv mc /usr/local/bin/mc
4135
- name: configure minio client
36+
env:
37+
PDL_WEBSITE_S3_ENDPOINT: ${{ secrets.PDL_WEBSITE_S3_ENDPOINT }}
38+
PDL_WEBSITE_S3_ACCESS_KEY: ${{ secrets.PDL_WEBSITE_S3_ACCESS_KEY }}
39+
PDL_WEBSITE_S3_SECRET_KEY: ${{ secrets.PDL_WEBSITE_S3_SECRET_KEY }}
4240
run: |
43-
mc alias set pdl $PDL_WEBSITE_S3_ENDPOINT $PDL_WEBSITE_S3_ACCESS_KEY $PDL_WEBSITE_S3_SECRET_KEY --api s3v4
41+
mc alias set pdl {{$PDL_WEBSITE_S3_ENDPOINT $PDL_WEBSITE_S3_ACCESS_KEY $PDL_WEBSITE_S3_SECRET_KEY --api s3v4
4442
4543
- name: install frontend dependencies
4644
run: npm ci # change this to npm, pnpm or bun depending on which one you use.

0 commit comments

Comments
 (0)