Skip to content

Commit 98ae98c

Browse files
committed
doc: attempt 3 to get react viewer live on github pages
TODO: how do we get the iframe to be full height? i've hard-coded a pixel height for now. Signed-off-by: Nick Mitchell <[email protected]>
1 parent ff73127 commit 98ae98c

File tree

3 files changed

+25
-14
lines changed

3 files changed

+25
-14
lines changed

.github/workflows/mkdocs-gh-pages.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -46,20 +46,6 @@ jobs:
4646
run: mkdocs build --config-file ./mkdocs.yml --strict --site-dir ./_site
4747
env:
4848
CI: true
49-
# Viewer
50-
- name: Set up node
51-
uses: actions/setup-node@v4
52-
with:
53-
node-version: 22
54-
- name: Install dependencies
55-
working-directory: ./pdl-live-react
56-
run: npm ci
57-
- name: Build viewer
58-
working-directory: ./pdl-live-react
59-
run: npm run build
60-
- name: Copy viewer
61-
working-directory: ./pdl-live-react
62-
run: cp -a ./dist ../viewer
6349
# Deploy
6450
- name: Upload artifact
6551
uses: actions/upload-pages-artifact@v3

docs/viewer.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
---
2+
hide:
3+
- navigation
4+
- toc
5+
- footer
6+
---
7+
8+
<style>
9+
.md-typeset {
10+
margin: 0;
11+
padding: 0;
12+
}
13+
.md-grid {margin-top: 0;}
14+
.md-typeset > h1,
15+
.md-content__button {
16+
display: none;
17+
}
18+
iframe {
19+
width: 100%;
20+
min-height: 800px; /* TODO */
21+
}
22+
</style>
23+
24+
<iframe src="https://pdl.s3-web.us-east.cloud-object-storage.appdomain.cloud/" frameborder="0" height="100%"></iframe>

mkdocs.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ nav:
4646
- Tutorial: tutorial.md
4747
- API Reference: api_reference.md
4848
- Contribute: contrib.md
49+
- Viewer: viewer.md
4950

5051
# Define some IBM colors
5152
extra_css:

0 commit comments

Comments
 (0)