Skip to content

Commit a543989

Browse files
committed
fix: avoid use of patternfly Card isClickable
problematic with z-index clicks and requires a global dom id for the click area. problemtic! Signed-off-by: Nick Mitchell <[email protected]>
1 parent 290f5e2 commit a543989

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

pdl-live-react/src/view/transcript/BreadcrumbBar.css

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@
66
/** Size factor relative to 1em */
77
--pdl-bb: 0.625;
88

9-
/** So that clicks get sent here first, not to the <Card isClickable/> used in <TranscriptItem/> */
10-
z-index: 1000;
11-
129
list-style: none;
1310
display: inline-block;
1411
font-size: calc(var(--pdl-bb) * 1em);

pdl-live-react/src/view/transcript/Transcript.css

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
.pdl-transcript-item {
2+
&:hover:before {
3+
border-color: var(--pf-v6-c-card--m-selectable--hover--BorderColor);
4+
}
25
&:first-child {
36
/* margin-top: 1em; */
47
}

pdl-live-react/src/view/transcript/TranscriptItem.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -96,18 +96,12 @@ export default function TranscriptItem(props: Props) {
9696
key={props.ctx.id}
9797
id={props.ctx.id}
9898
onClick={drilldown}
99-
isClickable
10099
className={
101100
"pdl-transcript-item" + (props.className ? " " + props.className : "")
102101
}
103102
data-id={props.ctx.id}
104103
>
105-
<CardHeader
106-
selectableActions={{
107-
onClickAction: drilldown,
108-
selectableActionAriaLabelledby: props.ctx.id,
109-
}}
110-
>
104+
<CardHeader>
111105
<CardTitle>{headerContent}</CardTitle>
112106
</CardHeader>
113107

0 commit comments

Comments
 (0)