Skip to content

Commit b2e19cf

Browse files
committed
fix: restore top-level breadcrumbs
These got lost in a recent refactoring Signed-off-by: Nick Mitchell <[email protected]>
1 parent 4951581 commit b2e19cf

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed

pdl-live-react/src/App.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export default function App() {
2626
<Route
2727
key={demo.name}
2828
path={`/demos/${demo.name}`}
29-
element={<Demo value={demo.trace} />}
29+
element={<Demo name={demo.name} value={demo.trace} />}
3030
/>
3131
))}
3232

pdl-live-react/src/Demo.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,14 @@ import Page from "./Page"
22
import Viewer from "./Viewer"
33

44
type Props = {
5+
name: string
56
value: string
67
}
78

8-
export default function Demo(props: Props) {
9+
export default function Demo({ name, value }: Props) {
910
return (
10-
<Page>
11-
<Viewer {...props} />
11+
<Page breadcrumb1="Demo" breadcrumb2={name}>
12+
<Viewer value={value} />
1213
</Page>
1314
)
1415
}

pdl-live-react/src/Page.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export default function PDLPage({ breadcrumb1, breadcrumb2, children }: Props) {
6060
>
6161
<PageSection
6262
isFilled
63-
hasOverflowScroll
63+
hasOverflowScroll={false}
6464
aria-label="PDL Viewer main section"
6565
>
6666
<DrawerContext.Provider value={setDrawerContent}>

pdl-live-react/src/Uploader.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ export default function Uploader() {
9797
)
9898

9999
return (
100-
<Page>
100+
<Page breadcrumb1="Uploader" breadcrumb2={filename}>
101101
<Form>
102102
<FormGroup fieldId="text-file-with-restrictions-example">
103103
<FileUpload

pdl-live-react/src/Viewer.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ export default function Viewer({ value }: { value: string }) {
3434
key="#transcript"
3535
href="#transcript"
3636
eventKey="#transcript"
37+
className="pdl-viewer-tab"
3738
title={<TabTitleText>Transcript</TabTitleText>}
3839
>
3940
<Transcript data={data} />
@@ -42,6 +43,7 @@ export default function Viewer({ value }: { value: string }) {
4243
key="#source"
4344
href="#source"
4445
eventKey="#source"
46+
className="pdl-viewer-tab"
4547
title={<TabTitleText>Source</TabTitleText>}
4648
>
4749
<Code block={data} darkMode={darkMode} limitHeight={false} />
@@ -50,6 +52,7 @@ export default function Viewer({ value }: { value: string }) {
5052
key="#raw"
5153
href="#raw"
5254
eventKey="#raw"
55+
className="pdl-viewer-tab"
5356
title={<TabTitleText>Raw Trace</TabTitleText>}
5457
>
5558
<Code block={data} darkMode={darkMode} limitHeight={false} raw />

0 commit comments

Comments
 (0)