Skip to content

Commit ca6213d

Browse files
committed
fix: remove more remnants of id and clickable cards in react viewer
Signed-off-by: Nick Mitchell <[email protected]>
1 parent 333e52a commit ca6213d

File tree

2 files changed

+2
-14
lines changed

2 files changed

+2
-14
lines changed

pdl-live-react/src/view/transcript/Defs.tsx

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ const alignCenter = { default: "alignItemsCenter" as const }
3434
export default function Defs({ defs, ctx }: Props) {
3535
const entries = Object.entries(defs)
3636
return entries.map(([key, value]) => {
37-
const id = "defs-" + ctx.id + "-" + key
3837
const breadcrumbs = (
3938
<BreadcrumbBar>
4039
<Def ctx={ctx} def={key} value={value} />
@@ -51,25 +50,17 @@ export default function Defs({ defs, ctx }: Props) {
5150
return (
5251
<Card
5352
isCompact
54-
isClickable
5553
onClick={drilldown}
5654
key={key}
5755
className="pdl-transcript-item"
58-
data-id={id}
5956
>
60-
<CardHeader
61-
id={id}
62-
selectableActions={{
63-
onClickAction: drilldown,
64-
selectableActionAriaLabelledby: id,
65-
}}
66-
>
57+
<CardHeader>
6758
<Flex alignItems={alignCenter}>
6859
<FlexItem className="pdl-block-icon">
6960
<EqualsIcon />
7061
</FlexItem>
7162

72-
<CardTitle id={id}>{breadcrumbs}</CardTitle>
63+
<CardTitle>{breadcrumbs}</CardTitle>
7364
</Flex>
7465
</CardHeader>
7566

pdl-live-react/src/view/transcript/TranscriptItem.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,10 @@ export default function TranscriptItem(props: Props) {
9393

9494
return (
9595
<Card
96-
key={props.ctx.id}
97-
id={props.ctx.id}
9896
onClick={drilldown}
9997
className={
10098
"pdl-transcript-item" + (props.className ? " " + props.className : "")
10199
}
102-
data-id={props.ctx.id}
103100
>
104101
<CardHeader>
105102
<CardTitle>{headerContent}</CardTitle>

0 commit comments

Comments
 (0)