Skip to content

Commit d2a99ff

Browse files
Disable metrics from the exporter itself by default
Signed-off-by: Mu Chen <[email protected]>
1 parent 60825cd commit d2a99ff

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ the [IBM SAN Volume Controller](https://www.ibm.com/us-en/marketplace/san-volume
1515
| config.file | Path to configuration file | spectrumVirtualize.yml |
1616
| web.telemetry-path | Path under which to expose metrics | /metrics |
1717
| web.listen-address | Address on which to expose metrics and web interface | :9119 |
18-
| web.disable-exporter-metrics | Exclude metrics about the exporter itself (promhttp_*, process_*, go_*) | false |
18+
| web.disable-exporter-metrics | Exclude metrics about the exporter itself (promhttp_*, process_*, go_*) | true |
1919
| --collector.name | Collector are enabled, the name means name of CLI Command | By default enabled collectors: lssystem and lssystemstats. |
2020
| --no-collector.name | Collectors that are enabled by default can be disabled, the name means name of CLI Command | By default disabled collectors: lsnodestats, lsmdisk, lsmdiskgrp, lsvdisk and lsvdiskcopy. |
2121

@@ -67,7 +67,7 @@ targets:
6767
6868
| CLI Command | Description | Default | Metrics | Total number of metrics |
6969
| --- | --- | --- | --- | --- |
70-
| - | Metrics from the exporter itself. | Enabled | [List](docs/exporter_metrics.md) | 35 |
70+
| - | Metrics from the exporter itself. | Disabled | [List](docs/exporter_metrics.md) | 35 |
7171
| lssystem | Get a detailed view of a clustered system (system). | Enabled | [List](docs/lssystem_metrics.md) | 57 |
7272
| lssystemstats | Get the most recent values of all node statistics in a system. | Enabled | [List](docs/lssystemstats_metrics.md) | 49 |
7373
| lsnodestats | Ge the most recent values of statistics for all nodes. | Disabled | [List](docs/lsnodestats_metrics.md)| 46 |

go.mod

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ go 1.12
55
require (
66
github.com/gorilla/csrf v1.7.0
77
github.com/gorilla/mux v1.8.0
8-
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
9-
github.com/modern-go/reflect2 v1.0.1 // indirect
108
github.com/prometheus/client_golang v1.2.1
119
github.com/prometheus/common v0.7.0
1210
github.com/tidwall/gjson v1.3.5

main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ var (
1919
configFile = kingpin.Flag("config.file", "Path to configuration file.").Default("spectrumVirtualize.yml").String()
2020
metricsPath = kingpin.Flag("web.telemetry-path", "Path under which to expose metrics.").Default("/metrics").String()
2121
listenAddress = kingpin.Flag("web.listen-address", "Address on which to expose metrics and web interface.").Default(":9119").String()
22-
disableExporterMetrics = kingpin.Flag("web.disable-exporter-metrics", "Exclude metrics about the exporter itself (promhttp_*, process_*, go_*).").Bool()
22+
disableExporterMetrics = kingpin.Flag("web.disable-exporter-metrics", "Exclude metrics about the exporter itself (promhttp_*, process_*, go_*).").Default("true").Bool()
2323
// maxRequests = kingpin.Flag("web.max-requests", "Maximum number of parallel scrape requests. Use 0 to disable.").Default("40").Int()
2424
cfg *utils.Config
2525
enableCollector bool = true

0 commit comments

Comments
 (0)