ci: Generate tags using docker/metadata-action (#4)

Use the `docker/metadata-action` to generate image tags, remove push target from Makefile

Signed-off-by: Christian Kadner <[email protected]>

Author: ckadner

.github/workflows/build.yml

@@ -40,13 +40,15 @@ jobs:
 
     - name: "Log in to Github Container registry"
       uses: docker/login-action@v3
+      if: github.event_name != 'pull_request'
       with:
         registry: ghcr.io
         username: ${{ github.actor }}
         password: ${{ secrets.GITHUB_TOKEN }}
 
     - name: "Log in to quay"
       uses: docker/login-action@v3
+      if: github.event_name != 'pull_request'
       with:
         registry: quay.io
         username: wxpe+github_pusher_bot
@@ -73,15 +75,25 @@ jobs:
         fi
         echo "CACHE_TO=$CACHE_TO" >> $GITHUB_ENV
 
-    - name: "push tags"
-      run: echo "PUSH_TAGS=$(scripts/get_image_tags.sh ${QUAY_REPOSITORY} | tr -s '[:blank:]' ',')" >> $GITHUB_ENV
+    - name: "Generate tags"
+      id: meta
+      uses: docker/metadata-action@v5
+      with:
+        images: |
+          ${{ env.QUAY_REPOSITORY }}
+        tags: |
+          type=ref,event=branch
+          type=semver,pattern={{version}}
+          type=semver,pattern={{major}}.{{minor}}
+          type=sha,enable=true,priority=100,prefix=,suffix=,format=short
+          type=sha,enable=true,priority=100,prefix=${{ github.ref_name }}.,suffix=,format=short
 
     - name: "Build and push"
       uses: docker/build-push-action@v5
       with:
         context: .
         target: router-release
-        tags: ${{ env.PUSH_TAGS }}
+        tags: ${{ steps.meta.outputs.tags }}
         cache-from: type=registry,ref=${{ env.CACHE_IMAGE }}
         cache-to: ${{ env.CACHE_TO }}
         push: ${{ github.event_name != 'pull_request' }}

Makefile

@@ -28,12 +28,3 @@ build-router: ##
 	--build-arg BUILDKIT_INLINE_CACHE=1 \
 	--tag "$(server_image_name)" .
 	docker images
-
-.PHONY: push-router-image
-push-router-image: ##
-	@for tag in $$(./scripts/get_image_tags.sh); do \
-		image_to_push="$(server_image_repo):$${tag}"; \
-		docker tag "$(server_image_name)" "$${image_to_push}"; \
-		echo "Pushing image $${image_to_push}"; \
-		docker push --quiet "$${image_to_push}"; \
-	done