Skip to content

Commit d9ade6a

Browse files
lingbinmeta-codesync[bot]
authored andcommitted
refactor: Remove redundant tryMapToRange<StringView> declaration (facebookincubator#16385)
Summary: VectorHasher has two tryMapToRange template specializations: `tryMapToRange<bool>` and `tryMapToRange<StringView>`. The `tryMapToRange<StringView>` template specialization was declared twice. This patch removes the redundant declaration. No functional changes. Pull Request resolved: facebookincubator#16385 Reviewed By: kKPulla Differential Revision: D93285257 Pulled By: jainxrohit fbshipit-source-id: ce314691513cae6bfef8c86736c547e24d376e04
1 parent 1aee3b4 commit d9ade6a

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

velox/exec/VectorHasher.h

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -646,14 +646,6 @@ bool VectorHasher::makeValueIdsForRows<TypeKind::VARCHAR>(
646646
template <>
647647
void VectorHasher::analyzeValue(StringView value);
648648

649-
template <>
650-
inline bool VectorHasher::tryMapToRange(
651-
const StringView* /*values*/,
652-
const SelectivityVector& /*rows*/,
653-
uint64_t* /*result*/) {
654-
return false;
655-
}
656-
657649
template <>
658650
inline uint64_t VectorHasher::valueId(StringView value) {
659651
auto size = value.size();
@@ -748,10 +740,12 @@ inline bool VectorHasher::tryMapToRange(
748740
}
749741

750742
template <>
751-
bool VectorHasher::tryMapToRange(
743+
inline bool VectorHasher::tryMapToRange(
752744
const StringView* /*values*/,
753745
const SelectivityVector& /*rows*/,
754-
uint64_t* /*result*/);
746+
uint64_t* /*result*/) {
747+
return false;
748+
}
755749

756750
template <>
757751
bool VectorHasher::makeValueIdsFlatNoNulls<bool>(

0 commit comments

Comments
 (0)