fix(api): Add custom JSON marshaling for InstancePrototype interface fields #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeifferj
force-pushed
the
fix/instance-prototype-json-marshaling
branch
from
2ea40fe to
4c6e54c
Compare
…fields Instance provisioning fails with "Expected only one oneOf fields to be set: got 0" errors when using InstancePrototype types with interface-typed fields. Go's default JSON marshaling omits interface-typed fields in certain contexts. oneOf discriminator fields (image, zone, vpc, primary_network_attachment) are missing from the JSON payload, causing VPC API validation to fail. This commit adds custom MarshalJSON methods to all InstancePrototype variant types that explicitly serialize all fields including interface types. Adds MarshalJSON() method requirement to InstancePrototypeIntf interface. This only affects code that implements this interface (SDK-generated types already comply). Fixes: IBM#133 Signed-off-by: Josephine Pfeiffer <[email protected]>
pfeifferj
force-pushed
the
fix/instance-prototype-json-marshaling
branch
from
4c6e54c to
d51de4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instance provisioning fails with "Expected only one oneOf fields to be set: got 0" errors when using InstancePrototype types with interface-typed fields.
Go's default JSON marshaling omits interface-typed fields in certain contexts. oneOf discriminator fields (image, zone, vpc, primary_network_attachment) are missing from the JSON payload, causing VPC API validation to fail.
This commit adds custom MarshalJSON methods to 8 InstancePrototype variant types that explicitly serialize all fields including interface types.
Fixes: #133