couple of unit tests

Author: pcoop

__tests__/api/BundleDeploy/BundleDeployer.test.ts

@@ -13,6 +13,7 @@ import { BundleDeployer } from "../../../src/api/BundleDeploy/BundleDeployer";
 import { IHandlerParameters } from "@brightside/imperative";
 import * as DeployBundleDefinition from "../../../src/cli/deploy/bundle/DeployBundle.definition";
 import * as fse from "fs-extra";
+import { ZosmfSession, SubmitJobs, List } from "@brightside/core";
 
 
 const DEFAULT_PARAMTERS: IHandlerParameters = {
@@ -55,6 +56,44 @@ const DEFAULT_PARAMTERS: IHandlerParameters = {
 
 describe("BundleDeployer01", () => {
 
+    it("should complain with missing zOSMF profile for deploy", async () => {
+
+        let parms: IHandlerParameters;
+        parms = DEFAULT_PARAMTERS;
+        setCommonParmsForDeployTests(parms);
+        parms.arguments.csdgroup = "12345678";
+
+        // Create a Bundle
+        const bd = new BundleDeployer(parms);
+
+        let err: Error;
+        try {
+          const response = await bd.deployBundle();
+        } catch (e) {
+          err = e;
+        }
+        expect(err).toBeDefined();
+        expect(err.message).toMatchSnapshot();
+    });
+    it("should complain with missing zOSMF profile for undeploy", async () => {
+
+        let parms: IHandlerParameters;
+        parms = DEFAULT_PARAMTERS;
+        setCommonParmsForDeployTests(parms);
+        parms.arguments.csdgroup = "12345678";
+
+        // Create a Bundle
+        const bd = new BundleDeployer(parms);
+
+        let err: Error;
+        try {
+          const response = await bd.undeployBundle();
+        } catch (e) {
+          err = e;
+        }
+        expect(err).toBeDefined();
+        expect(err.message).toMatchSnapshot();
+    });
     it("should generate deploy JCL for csdgroup", () => {
 
         let parms: IHandlerParameters;

__tests__/api/BundleDeploy/__snapshots__/BundleDeployer.test.ts.snap

@@ -1,5 +1,9 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`BundleDeployer01 should complain with missing zOSMF profile for deploy 1`] = `"Expect Error: Required parameter 'hostname' must be defined"`;
+
+exports[`BundleDeployer01 should complain with missing zOSMF profile for undeploy 1`] = `"Expect Error: Required parameter 'hostname' must be defined"`;
+
 exports[`BundleDeployer01 should generate deploy JCL for csdgroup 1`] = `
 "//DFHDPLOY JOB DFHDPLOY,CLASS=A,MSGCLASS=X,TIME=NOLIMIT
 //DFHDPLOY EXEC PGM=DFHDPLOY,REGION=100M

src/api/BundleDeploy/BundleDeployer.ts

@@ -47,7 +47,7 @@ export class BundleDeployer {
     ParmValidator.validateDeploy(this.params);
 
     // Create a zosMF session
-    const session = this.createZosMFSession();
+    const session = await this.createZosMFSession();
 
     // Check that the CICS dataset value looks valid and can be viewed
     await this.checkHLQDatasets(session);
@@ -71,7 +71,7 @@ export class BundleDeployer {
     ParmValidator.validateUndeploy(this.params);
 
     // Create a zosMF session
-    const session = this.createZosMFSession();
+    const session = await this.createZosMFSession();
 
     // Check that the CICS dataset value looks valid and can be viewed
     await this.checkHLQDatasets(session);
@@ -164,7 +164,7 @@ export class BundleDeployer {
   }
 
 
-  private createZosMFSession(): Session {
+  private async createZosMFSession(): Promise<Session> {
     // Create a zosMF session
     const zosmfProfile = this.params.profiles.get("zosmf");