rename parms 5

Author: pcoop

docs-internal/CLIReadme.md

@@ -40,7 +40,7 @@ the target group of CICS regions\.
 	* Specifies the name of the CICS BUNDLE resource (up to 8 characters) to deploy or
 undeploy.
 
-*   `--bundle-directory`  | `--bd` | `--bundledir` *(string)*
+*   `--bundle-directory`  | `--bd` | `--bundledir` | `--bundle-dir` *(string)*
 
 	* Specifies the location of the CICS bundle (up to 255 characters) on zFS.
 
@@ -283,7 +283,7 @@ If a bundle is deployed then a resource is defined in the BAS data repository;
 if a bundle is undeployed then the definition is removed. The --csd-group and
 --res-group options are mutually exclusive.
 
-*   `--target-directory`  | `--td` | `--targetdir` *(string)*
+*   `--target-directory`  | `--td` | `--targetdir` | `--target-dir` *(string)*
 
 	* Specifies the target zFS location to which CICS bundles should be uploaded (up
 to 255 characters).
@@ -365,7 +365,7 @@ datasets can be found in the target environment.
 	* Specifies the High Level Qualifier (up to 35 characters) at which the CPSM
 datasets can be found in the target environment.
 
-*   `--target-directory`  | `--td` | `--targetdir` *(string)*
+*   `--target-directory`  | `--td` | `--targetdir` | `--target-dir` *(string)*
 
 	* Specifies the target zFS location to which CICS bundles should be uploaded (up
 to 255 characters).
@@ -479,7 +479,7 @@ Push a CICS bundle from the working directory to a target CICSplex\.
 	* Specifies the name of the CICS BUNDLE resource (up to 8 characters) to deploy or
 undeploy.
 
-*   `--target-directory`  | `--td` | `--targetdir` *(string)*
+*   `--target-directory`  | `--td` | `--targetdir` | `--target-dir` *(string)*
 
 	* Specifies the target zFS location in which the CICS bundle is to be created (up
 to 255 characters)

src/api/BundlePush/BundlePusher.ts

@@ -372,7 +372,7 @@ export class BundlePusher {
       }
 
       this.sshOutputText = "";
-      const shell = await Shell.executeSshCwd(sshSession, sshCommand, directory, this.sshOutput.bind(this));
+      const sshReturnCode = await Shell.executeSshCwd(sshSession, sshCommand, directory, this.sshOutput.bind(this));
       const upperCaseOutputText = this.sshOutputText.toUpperCase();
 
       // Note that FSUM9195 can imply that we've tried to delete the
@@ -383,19 +383,19 @@ export class BundlePusher {
       const countFSUM9195 = (upperCaseOutputText.match(/FSUM9195/g) || []).length;
       if (countFSUM9195 !== 0 &&
           countFSUM === countFSUM9195 &&
-          shell === 1) {
+          sshReturnCode === 1) {
         isOnlyFSUM9195 = true;
       }
 
       // Now check
       // A. If exit code is non zero
       // B. FSUM9195 is not the only FSUM error
-      if (shell !== 0 && !isOnlyFSUM9195) {
+      if (sshReturnCode !== 0 && !isOnlyFSUM9195) {
         // if we've not already logged the output, log it now
         if (this.params.arguments.verbose !== true) {
           this.params.response.console.log(Buffer.from(this.sshOutputText));
         }
-        throw new Error("The output from the remote command implied that an error occurred, return code " + shell + ".");
+        throw new Error("The output from the remote command implied that an error occurred, return code " + sshReturnCode + ".");
       }
     }
     catch (error) {

src/cli/deploy/bundle/options/Bundledir.option.ts

@@ -19,7 +19,7 @@ const MAX_LENGTH = 255;
  */
 export const BundledirOption: ICommandOptionDefinition = {
     name: "bundle-directory",
-    aliases: ["bd", "bundledir"],
+    aliases: ["bd", "bundledir", "bundle-dir"],
     type: "string",
     required: true,
     stringLengthRange: [1, MAX_LENGTH],

src/cli/push/bundle/options/Targetdir.option.ts

@@ -19,7 +19,7 @@ const MAX_LENGTH = 255;
  */
 export const TargetdirOption: ICommandOptionDefinition = {
     name: "target-directory",
-    aliases: ["td", "targetdir"],
+    aliases: ["td", "targetdir", "target-dir"],
     type: "string",
     required: true,
     stringLengthRange: [1, MAX_LENGTH],

src/imperative.ts

@@ -111,7 +111,7 @@ const config: IImperativeConfig = {
                 description: "Specifies the target zFS location to which CICS bundles should be uploaded (up to 255 characters).",
                 type: "string",
                 name: "target-directory",
-                aliases: ["td", "targetdir"],
+                aliases: ["td", "targetdir", "target-dir"],
                 stringLengthRange: [1, MAX_TARGETDIR_LENGTH],
                 required: false
               },