Fix nodjesapp dir validation bug

Author: matthewpwilson

__tests__/api/BundleContent/BundleMocked.test.ts

@@ -144,9 +144,15 @@ describe("MockedFilesystemTests", () => {
           if (path.endsWith("nodejsapps")) {
             return false;
           }
+          if (path.endsWith(".nodejsapp")) {
+            return false;
+          }
           if (path.endsWith("cics.xml")) {
             return false;
           }
+          if (path.endsWith(".profile")) {
+            return false;
+          }
           if (path.endsWith(".zosattributes")) {
             return false;
           }
@@ -205,7 +211,7 @@ describe("MockedFilesystemTests", () => {
         expect(err).toBeDefined();
         expect(err.message).toContain("cics-deploy requires write permission to: ");
     });
-    it.skip("should detect unwritable nodejsapps directory", () => {
+    it("should detect unwritable nodejsapps directory", () => {
         jest.spyOn(fs, "existsSync").mockImplementation((path: string) => {
             if (path.endsWith("nodejsapps")) {
               return false;

src/api/BundleContent/NodejsappBundlePart.ts

@@ -160,16 +160,15 @@ export class NodejsappBundlePart extends BundlePart {
       catch (err) {
         throw new Error("cics-deploy requires write permission to: " + this.bundleDirectory);
       }
-      return;
+      // Do we have write permission to the nodejsapp dir?
+      try {
+        BundlePart.fs.accessSync(this.nodejsappsDir, BundlePart.fs.constants.W_OK);
+      }
+      catch (err) {
+        throw new Error("cics-deploy requires write permission to: " + this.nodejsappsDir);
+      }
     }
 
-    // Do we have write permission to the nodejsapp dir?
-    try {
-      BundlePart.fs.accessSync(this.nodejsappsDir, BundlePart.fs.constants.W_OK);
-    }
-    catch (err) {
-      throw new Error("cics-deploy requires write permission to: " + this.nodejsappsDir);
-    }
 
     // Does the .nodejsapp appear to be saveable?
     BundlePart.ensureFileSaveable(this.nodejsappFile, this.overwrite);