Fix: inject logger in services instead of using $this->get() in controller

Author: BeBlood

Controller/PaymentGatewayController.php

@@ -21,21 +21,20 @@ class PaymentGatewayController extends AbstractController
      */
     private $paymentManager;
 
-    public function __construct(PaymentManager $paymentManager)
+    public function __construct(PaymentManager $paymentManager, Logger $logger)
     {
         $this->paymentManager = $paymentManager;
+        $this->logger = $logger;
     }
 
     /**
      * @Route("/{configuration_alias}/callback", name="idci_payment_payment_gateway_callback", methods={"GET", "POST"})
      */
     public function callbackAction(Request $request, EventDispatcherInterface $dispatcher, $configuration_alias)
     {
-        $logger = $this->container->get('monolog.logger.payment');
-
         $data = $request->isMethod(Request::METHOD_POST) ? $request->request->all() : $request->query->all();
 
-        $logger->info(
+        $this->logger->info(
             sprintf(
                 '[gateway configuration alias: %s, data: %s, ip: %s]',
                 $configuration_alias,

Resources/config/services.yml

@@ -9,6 +9,11 @@ services:
         resource: '../../*'
         exclude: '../../{Entity,Repository,Tests,Event/Subscriber}'
 
+    # Controller
+    IDCI\Bundle\PaymentBundle\Controller\PaymentGatewayController:
+        arguments:
+            $logger: '@monolog.logger.payment'
+
     # Manager
     Doctrine\Common\Persistence\ObjectManager: null