Skip to content

Commit cb98eaf

Browse files
committed
Fix: add try & catch on logger
1 parent a7dba88 commit cb98eaf

File tree

3 files changed

+27
-17
lines changed

3 files changed

+27
-17
lines changed

Controller/PaymentGatewayController.php

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,16 @@ public function callbackAction(Request $request, EventDispatcherInterface $dispa
3535
{
3636
$data = $request->isMethod(Request::METHOD_POST) ? $request->request->all() : $request->query->all();
3737

38-
$this->logger->info(
39-
sprintf(
40-
'[gateway configuration alias: %s, data: %s, ip: %s]',
41-
$configuration_alias,
42-
json_encode($data),
43-
json_encode($request->getClientIps())
44-
)
45-
);
38+
try {
39+
$this->logger->info(
40+
sprintf(
41+
'[gateway configuration alias: %s, data: %s, ip: %s]',
42+
$configuration_alias,
43+
json_encode($data),
44+
json_encode($request->getClientIps())
45+
)
46+
);
47+
} catch (\Exception $e) {}
4648

4749
$paymentContext = $this
4850
->paymentManager

Event/Subscriber/LoggerTransactionEventSubscriber.php

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function approve(TransactionEvent $transactionEvent)
4949
return;
5050
}
5151

52-
$this->logger->info('Transaction approved: '.$transactionEvent->getTransaction()->getId());
52+
$this->log('Transaction approved: '.$transactionEvent->getTransaction()->getId());
5353
}
5454

5555
public function cancel(TransactionEvent $transactionEvent)
@@ -58,7 +58,7 @@ public function cancel(TransactionEvent $transactionEvent)
5858
return;
5959
}
6060

61-
$this->logger->info('Transaction canceled: '.$transactionEvent->getTransaction()->getId());
61+
$this->log('Transaction canceled: '.$transactionEvent->getTransaction()->getId());
6262
}
6363

6464
public function create(TransactionEvent $transactionEvent)
@@ -67,7 +67,7 @@ public function create(TransactionEvent $transactionEvent)
6767
return;
6868
}
6969

70-
$this->logger->info('Transaction created: '.$transactionEvent->getTransaction()->getId());
70+
$this->log('Transaction created: '.$transactionEvent->getTransaction()->getId());
7171
}
7272

7373
public function fail(TransactionEvent $transactionEvent)
@@ -76,7 +76,7 @@ public function fail(TransactionEvent $transactionEvent)
7676
return;
7777
}
7878

79-
$this->logger->info('Transaction failed: '.$transactionEvent->getTransaction()->getId());
79+
$this->log('Transaction failed: '.$transactionEvent->getTransaction()->getId());
8080
}
8181

8282
public function pend(TransactionEvent $transactionEvent)
@@ -85,7 +85,7 @@ public function pend(TransactionEvent $transactionEvent)
8585
return;
8686
}
8787

88-
$this->logger->info('Transaction pending: '.$transactionEvent->getTransaction()->getId());
88+
$this->log('Transaction pending: '.$transactionEvent->getTransaction()->getId());
8989
}
9090

9191
public function unverify(TransactionEvent $transactionEvent)
@@ -94,6 +94,12 @@ public function unverify(TransactionEvent $transactionEvent)
9494
return;
9595
}
9696

97-
$this->logger->info('Transaction unverified: '.$transactionEvent->getTransaction()->getId());
97+
$this->log('Transaction unverified: '.$transactionEvent->getTransaction()->getId());
98+
}
99+
100+
private function log(string $message) {
101+
try {
102+
$this->logger->info($message);
103+
} catch (\Exception $e) {}
98104
}
99105
}

Payment/PaymentContext.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,11 @@ public function handleGatewayCallback(Request $request): Transaction
8888
}
8989

9090
if ($this->logger) {
91-
$this->logger->info('Gateway response: ', [
92-
'response' => json_encode($gatewayResponse->toArray()),
93-
]);
91+
try {
92+
$this->logger->info('Gateway response: ', [
93+
'response' => json_encode($gatewayResponse->toArray()),
94+
]);
95+
} catch (\Exception $e) {}
9496
}
9597

9698
return $transaction

0 commit comments

Comments
 (0)