Skip to content

Commit 71df294

Browse files
committed
Remove HEAD methods from GET routes
Although not 100% correct following RESTful definition, we drop them as it only introduces confusion in our case.
1 parent b636f29 commit 71df294

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

deepaas/api/v2/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def get_app(enable_train=True, enable_predict=True):
3838

3939
v2_debug.setup_debug()
4040

41-
APP.router.add_get('/', get_version, name="v2")
41+
APP.router.add_get('/', get_version, name="v2", allow_head=False)
4242
v2_debug.setup_routes(APP)
4343
v2_model.setup_routes(APP)
4444
v2_train.setup_routes(APP, enable=enable_train)

deepaas/api/v2/debug.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,4 +94,4 @@ async def get(request, wsk_args=None):
9494

9595

9696
def setup_routes(app):
97-
app.router.add_get("/debug/", get)
97+
app.router.add_get("/debug/", get, allow_head=False)

deepaas/api/v2/models.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,13 @@ async def get(self, request, wsk_args=None):
8888

8989

9090
def setup_routes(app):
91-
app.router.add_get("/models/", index)
91+
app.router.add_get("/models/", index, allow_head=False)
9292

9393
# In the next lines we iterate over the loaded models and create the
9494
# different resources for each model. This way we can also load the
9595
# expected parameters if needed (as in the training method).
9696
for model_name, model_obj in model.V2_MODELS.items():
9797
hdlr = _get_handler(model_name, model_obj)
98-
app.router.add_get("/models/%s/" % model_name, hdlr.get)
98+
app.router.add_get("/models/%s/" % model_name,
99+
hdlr.get,
100+
allow_head=False)

deepaas/api/v2/train.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,12 @@ def setup_routes(app, enable=True):
140140
else:
141141
hdlr = utils.NotEnabledHandler()
142142
app.router.add_post("/models/%s/train/" % model_name, hdlr.post)
143-
app.router.add_get("/models/%s/train/" % model_name, hdlr.index)
144-
app.router.add_get("/models/%s/train/{uuid}" % model_name, hdlr.get)
143+
app.router.add_get("/models/%s/train/" % model_name,
144+
hdlr.index,
145+
allow_head=False)
146+
app.router.add_get("/models/%s/train/{uuid}" % model_name,
147+
hdlr.get,
148+
allow_head=False)
145149
app.router.add_delete(
146150
"/models/%s/train/{uuid}" % model_name,
147151
hdlr.delete

0 commit comments

Comments
 (0)