Skip to content

Commit 35b0431

Browse files
Copilotalvarolopez
andcommitted
refactor: address code review feedback for messenger record type filtering
Co-authored-by: alvarolopez <[email protected]>
1 parent 0041867 commit 35b0431

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

caso/messenger/__init__.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,10 @@ def push_to_all(self, records):
167167
ext.obj.push(filtered_records)
168168
else:
169169
LOG.debug(
170-
f"No records to push to messenger {messenger_name} "
171-
f"after filtering for record types: {record_types}"
170+
"No records to push to messenger %s "
171+
"after filtering for record types: %s",
172+
messenger_name,
173+
record_types,
172174
)
173175
except Exception as e:
174176
# Capture exception so that we can continue working

caso/tests/test_messenger.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,5 +189,7 @@ def test_valid_record_types_contains_all_types(self):
189189

190190
def test_record_type_map_matches_valid_record_types(self):
191191
"""Test that RECORD_TYPE_MAP keys match VALID_RECORD_TYPES."""
192-
assert set(caso.messenger.RECORD_TYPE_MAP.keys()) == \
193-
caso.messenger.VALID_RECORD_TYPES
192+
assert (
193+
set(caso.messenger.RECORD_TYPE_MAP.keys())
194+
== caso.messenger.VALID_RECORD_TYPES
195+
)

0 commit comments

Comments
 (0)