Fix flake8 and black code formatting issues

Co-authored-by: alvarolopez <[email protected]>

Author: Copilot

caso/tests/extract/test_manager.py

@@ -25,9 +25,11 @@
 from unittest import mock
 
 from caso.extract import manager
-import caso.manager  # Import to register the spooldir option
 
 CONF = cfg.CONF
+CONF.register_opts(
+    [cfg.StrOpt("spooldir", default="/var/spool/caso", help="Spool directory.")]
+)
 
 
 class TestCasoManager(unittest.TestCase):
@@ -152,58 +154,68 @@ def test_lastrun_is_invalid(self):
     def test_get_records_with_invalid_lastrun_continues(self):
         """Test that get_records continues when lastrun file is invalid."""
         self.flags(projects=["project1", "project2"])
-        
+
         # Mock the file system operations to test exception handling path
-        with unittest.mock.patch.object(self.manager, "get_project_vo", return_value="test-vo") as m_vo:
-            with unittest.mock.patch('os.path.exists', return_value=True):
+        with unittest.mock.patch.object(
+            self.manager, "get_project_vo", return_value="test-vo"
+        ) as m_vo:
+            with unittest.mock.patch("os.path.exists", return_value=True):
                 # One project gets invalid date, one gets valid date
                 file_contents = ["invalid-date-format", "2020-01-01 00:00:00"]
                 mock_file = unittest.mock.mock_open()
                 mock_file.return_value.read.side_effect = file_contents
-                
-                with unittest.mock.patch('builtins.open', mock_file):
-                    ret = self.manager.get_records()
-                    
-                    # Should call get_project_vo for both projects since VO lookup happens before lastrun
+
+                with unittest.mock.patch("builtins.open", mock_file):
+                    self.manager.get_records()
+
+                    # Should call get_project_vo for both projects since VO
+                    # lookup happens before lastrun
                     self.assertEqual(m_vo.call_count, 2)
                     m_vo.assert_any_call("project1")
                     m_vo.assert_any_call("project2")
-                    
-                    # One project should succeed - doesn't matter which one for this test
-                    # The key is that get_records continues processing despite one project failing
+
+                    # One project should succeed - doesn't matter which one
+                    # The key is that get_records continues processing
+                    # despite one project failing
                     self.m_extractor.assert_called_once()
                     args, kwargs = self.m_extractor.call_args
                     self.assertEqual(args[1], "test-vo")  # VO should be correct
-                    self.assertIn(args[0], ["project1", "project2"])  # Should be one of the projects
+                    # Should be one of the projects
+                    self.assertIn(args[0], ["project1", "project2"])
 
     def test_get_records_with_future_extract_from_continues(self):
         """Test that get_records continues when extract_from is in the future."""
         self.flags(projects=["project1", "project2"])
         future_date = datetime.datetime.now(tz.tzutc()) + datetime.timedelta(days=1)
         past_date = datetime.datetime.now(tz.tzutc()) - datetime.timedelta(days=1)
-        
+
         # Mock file system operations and return dates
-        with unittest.mock.patch.object(self.manager, "get_project_vo", return_value="test-vo") as m_vo:
-            with unittest.mock.patch('os.path.exists', return_value=True):
+        with unittest.mock.patch.object(
+            self.manager, "get_project_vo", return_value="test-vo"
+        ) as m_vo:
+            with unittest.mock.patch("os.path.exists", return_value=True):
                 # One project gets future date, one gets past date
                 file_contents = [str(future_date), str(past_date)]
                 mock_file = unittest.mock.mock_open()
                 mock_file.return_value.read.side_effect = file_contents
-                
-                with unittest.mock.patch('builtins.open', mock_file):
-                    ret = self.manager.get_records()
-                    
-                    # Should call get_project_vo for both projects since VO lookup happens before lastrun
+
+                with unittest.mock.patch("builtins.open", mock_file):
+                    self.manager.get_records()
+
+                    # Should call get_project_vo for both projects since VO
+                    # lookup happens before lastrun
                     self.assertEqual(m_vo.call_count, 2)
                     m_vo.assert_any_call("project1")
                     m_vo.assert_any_call("project2")
-                    
-                    # One project should succeed - doesn't matter which one for this test
-                    # The key is that get_records continues processing despite one project failing
+
+                    # One project should succeed - doesn't matter which one
+                    # The key is that get_records continues processing
+                    # despite one project failing
                     self.m_extractor.assert_called_once()
                     args, kwargs = self.m_extractor.call_args
                     self.assertEqual(args[1], "test-vo")  # VO should be correct
-                    self.assertIn(args[0], ["project1", "project2"])  # Should be one of the projects
+                    # Should be one of the projects
+                    self.assertIn(args[0], ["project1", "project2"])
 
     def test_get_lastrun_invalid_date_logs_exception(self):
         """Test that get_lastrun properly logs exceptions when date parsing fails."""
@@ -212,19 +224,19 @@ def test_get_lastrun_invalid_date_logs_exception(self):
         else:
             builtins_open = "__builtin__.open"
         fopen = unittest.mock.mock_open(read_data="invalid-date-format")
-        
+
         with unittest.mock.patch("os.path.exists") as path:
             with unittest.mock.patch(builtins_open, fopen):
                 with unittest.mock.patch("caso.extract.manager.LOG") as mock_log:
                     path.return_value = True
-                    
+
                     with self.assertRaises(ValueError):
                         self.manager.get_lastrun("test-project")
-                    
+
                     # Verify that both error and exception were logged
                     mock_log.error.assert_called_once()
                     mock_log.exception.assert_called_once()
-                    
+
                     # Check the error message contains the expected text
                     error_call = mock_log.error.call_args[0][0]
                     self.assertIn("Cannot read date from lastrun file", error_call)