record: use properties for {start,end}_time

Rather than modifying attributes directly, lets use properties and
setters/getters to modify the start and end times of a given record.

Author: alvarolopez

caso/extract/nova.py

@@ -76,12 +76,16 @@ def build_record(self, server, vo, images, flavors, users):
                           "file or set the correct properties in the "
                           "flavor." % flavor)
 
+        server_start = dateutil.parser.parse(server.created)
+        server_start = server_start.replace(tzinfo=None)
+
         r = record.CloudRecord(server.id,
                                CONF.site_name,
                                server.name,
                                server.user_id,
                                server.tenant_id,
                                vo,
+                               start_time=server_start,
                                compute_service=CONF.service_name,
                                status=status,
                                image_id=image_id,
@@ -198,14 +202,13 @@ def extract_for_project(self, project, extract_from, extract_to):
             records[instance_id].disk = usage["local_gb"]
 
             # Start time must be the time when the machine was created
-            started = server_start
-            records[instance_id].start_time = int(started.strftime("%s"))
+            started = records[instance_id].start_time
 
             # End time must ben the time when the machine was ended, but it may
             # be none
             if usage.get('ended_at', None) is not None:
                 ended = dateutil.parser.parse(usage["ended_at"])
-                records[instance_id].end_time = int(ended.strftime("%s"))
+                records[instance_id].end_time = ended
             else:
                 ended = None
 

caso/record.py

@@ -14,6 +14,7 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
+import datetime
 import json
 import pprint
 
@@ -129,6 +130,26 @@ def as_dict(self, version=None):
         return {k: v for k, v in self.map.items()
                 if k in self._version_field_map[version]}
 
+    @property
+    def start_time(self):
+        return self._start_time
+
+    @start_time.setter
+    def start_time(self, value):
+        if value and not isinstance(value, datetime.datetime):
+            raise ValueError("Dates must be datetime.datetime objects")
+        self._start_time = value
+
+    @property
+    def end_time(self):
+        return self._end_time
+
+    @end_time.setter
+    def end_time(self, value):
+        if value and not isinstance(value, datetime.datetime):
+            raise ValueError("Dates must be datetime.datetime objects")
+        self._end_time = value
+
     @property
     def map(self):
         d = {'VMUUID': self.uuid,
@@ -138,8 +159,10 @@ def map(self):
              'LocalGroupId': self.group_id,
              'FQAN': self.fqan,
              'Status': self.status,
-             'StartTime': self.start_time,
-             'EndTime': self.end_time,
+             'StartTime': self.start_time and int(
+                 self.start_time.strftime("%s")
+             ),
+             'EndTime': self.end_time and int(self.end_time.strftime("%s")),
              'SuspendDuration': self.suspend_duration,
              'WallDuration': self.wall_duration,
              'CpuDuration': self.cpu_duration,