Merge pull request #2554 from IFRCGo/chore/disable-local-unit-email-notifications

 Disable local unit email notification

Author: szabozoltan69

deploy/helm/ifrcgo-helm/values.yaml

@@ -272,8 +272,8 @@ cronjobs:
     schedule: '0 0 * * 0'
   - command: 'ingest_icrc'
     schedule: '0 3 * * 0'
-  - command: 'notify_validators'
-    schedule: '0 0 * * *'
+  # - command: 'notify_validators' 
+  #   schedule: '0 0 * * *'
   # https://github.com/jazzband/django-oauth-toolkit/blob/master/docs/management_commands.rst#cleartokens
   - command: 'oauth_cleartokens'
     schedule: '0 1 * * *'

local_units/management/commands/notify_validators.py

@@ -4,22 +4,24 @@
 from django.core.management.base import BaseCommand
 from django.template.loader import render_to_string
 from django.utils import timezone
-from sentry_sdk.crons import monitor
 
 from local_units.models import LocalUnit, Validator
 from local_units.utils import (
     get_email_context,
     get_local_unit_global_validators,
     get_local_unit_region_validators,
 )
-from main.sentry import SentryMonitor
+
+# from main.sentry import SentryMonitor
 from notifications.notification import send_notification
 
+# from sentry_sdk.crons import monitor
+
 
 class Command(BaseCommand):
     help = "Notify validators for the pending local units in different period of time"
 
-    @monitor(monitor_slug=SentryMonitor.NOTIFY_VALIDATORS)
+    # @monitor(monitor_slug=SentryMonitor.NOTIFY_VALIDATORS) # NOTE: Disabled for now
     def handle(self, *args, **options):
         self.stdout.write(self.style.NOTICE("Notifying the validators..."))
         # NOTE: In production use standard email notification time(7days/14days),shorter delays(1day/2days) elsewhere for testing

local_units/tasks.py

@@ -6,7 +6,6 @@
 
 from local_units.bulk_upload import BaseBulkUploadLocalUnit, BulkUploadHealthData
 from local_units.models import LocalUnit, LocalUnitBulkUpload, LocalUnitChangeRequest
-from notifications.notification import send_notification
 
 from .utils import (
     get_email_context,
@@ -15,6 +14,9 @@
     get_local_unit_region_validators,
 )
 
+# from notifications.notification import send_notification
+
+
 User = get_user_model()
 
 logger = logging.getLogger(__name__)
@@ -51,7 +53,7 @@ def send_local_unit_email(local_unit_id: int, new: bool = True):
         email_context["validator_email"] = user.email
         email_context["full_name"] = user.get_full_name()
         email_body = render_to_string("email/local_units/local_unit.html", email_context)
-        send_notification(email_subject, user.email, email_body, email_type)
+        print(email_subject, user.email, email_body, email_type)  # send_notification
 
 
 @shared_task
@@ -75,7 +77,7 @@ def send_validate_success_email(local_unit_id: int, message: str = ""):
     email_subject = "Your Local Unit Addition Request: Approved"
     email_body = render_to_string("email/local_units/local_unit.html", email_context)
     email_type = f"{message} Local Unit"
-    send_notification(email_subject, user.email, email_body, email_type)
+    print(email_subject, user.email, email_body, email_type)  # send_notification
     return email_context
 
 
@@ -102,7 +104,7 @@ def send_revert_email(local_unit_id: int, change_request_id: int):
     email_body = render_to_string("email/local_units/local_unit.html", email_context)
     email_type = "Revert Local Unit"
 
-    send_notification(email_subject, user.email, email_body, email_type)
+    print(email_subject, user.email, email_body, email_type)  # send_notification
     return email_context
 
 
@@ -129,7 +131,7 @@ def send_deprecate_email(local_unit_id: int):
     email_subject = "Your Local Unit Addition Request: Deprecated"
     email_body = render_to_string("email/local_units/local_unit.html", email_context)
     email_type = "Deprecate Local Unit"
-    send_notification(email_subject, user.email, email_body, email_type)
+    print(email_subject, user.email, email_body, email_type)  # send_notification
     return email_context
 
 

main/sentry.py

@@ -128,7 +128,7 @@ class SentryMonitor(models.TextChoices):
     INGEST_NS_DOCUMENT = "ingest_ns_document", "0 0 * * 0"
     INGEST_NS_INITIATIVES = "ingest_ns_initiatives", "0 0 * * 0"
     INGEST_ICRC = "ingest_icrc", "0 3 * * 0"
-    NOTIFY_VALIDATORS = "notify_validators", "0 0 * * *"
+    # NOTIFY_VALIDATORS = "notify_validators", "0 0 * * *" # NOTE: Disable local unit email notification for now
     OAUTH_CLEARTOKENS = "oauth_cleartokens", "0 1 * * *"
 
     @staticmethod