Better AppealFilter usage in DREF3

Author: szabozoltan69

dref/test_views.py

@@ -1803,7 +1803,7 @@ def test_superuser_can_access_list(self):
         response = self.client.get(self.url)
         self.assertEqual(response.status_code, status.HTTP_200_OK)
 
-    def test_normal_user_cannot_access_list(self):
+    def test_normal_user_can_access_list_also(self):
         self.client.force_authenticate(user=self.user)
         response = self.client.get(self.url)
         # self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)

dref/views.py

@@ -1,5 +1,4 @@
 import django.utils.timezone as timezone
-from django.apps import apps
 from django.contrib.auth.models import Permission
 from django.db import models
 from django.templatetags.static import static
@@ -18,6 +17,7 @@
 from rest_framework.exceptions import NotFound
 from reversion.views import RevisionMixin
 
+from api.models import AppealFilter
 from dref.filter_set import (
     ActiveDrefFilterSet,
     CompletedDrefOperationsFilterSet,
@@ -299,13 +299,15 @@ def get_nonsuperusers_excluded_codes(self):
         Accepts CSV values in AppealFilter.value like "MDRXX019,MDRYY036".
         """
         try:
-            AppealFilter = apps.get_model("api", "AppealFilter")
-            codes = list(AppealFilter.objects.values_list("value", flat=True))
+            if AppealFilter.objects.values_list("value", flat=True).filter(name="ingestAppealFilter").count() > 0:
+                codes_exc = AppealFilter.objects.values_list("value", flat=True).filter(name="ingestAppealFilter")[0].split(",")
+            else:
+                codes_exc = []
         except Exception:
             # If model/app not available, fail open (no extra exclusions)
             return set()
         excluded = set()
-        for code in codes:
+        for code in codes_exc:
             c = code.strip().upper()
             if c:
                 excluded.add(c)