refactor(dref): refactor dref finalize logic

Author: sudip-khanal

dref/migrations/0084_dref_original_language_and_more.py

@@ -20,6 +20,18 @@ def update_status(apps, schema_editor):
         Model.objects.filter(is_published=True).update(status=4)  # Published → APPROVED
         Model.objects.filter(is_published=False).update(status=1)  # Not published → DRAFT
 
+def update_original_language(apps, schema_editor):
+    """
+    Populate the original_language field with 'en' for all existing records.
+    """
+    models = [
+        "Dref",
+        "DrefOperationalUpdate",
+        "DrefFinalReport",
+    ]
+    for model_name in models:
+        Model = apps.get_model("dref", model_name)
+        Model.objects.update(original_language="en")
 
 class Migration(migrations.Migration):
 
@@ -80,4 +92,5 @@ class Migration(migrations.Migration):
             ),
         ),
         migrations.RunPython(update_status, reverse_code=migrations.RunPython.noop),
+        migrations.RunPython(update_original_language,reverse_code=migrations.RunPython.noop),
     ]

dref/migrations/0085_remove_dref_is_published_and_more.py

@@ -1,37 +1,55 @@
-# Generated by Django 4.2.19 on 2025-09-16 09:13
+# Generated by Django 4.2.19 on 2025-11-05 04:07
+
+from django.db import migrations, models
 
-from django.db import migrations
 
-def migrate_approved_status_to_new_value(apps, schema_editor):
-    """
-    Migrates the 'APPROVED' status from old value (4) to new value (3)
-    """
-    models = [
-        "Dref",
-        "DrefOperationalUpdate",
-        "DrefFinalReport",
-    ]
-    for model_name in models:
-        Model = apps.get_model("dref", model_name)
-        Model.objects.filter(status=4).update(status=3) 
 class Migration(migrations.Migration):
 
     dependencies = [
-        ("dref", "0084_dref_original_language_and_more"),
+        ('dref', '0084_dref_original_language_and_more'),
     ]
 
     operations = [
         migrations.RemoveField(
-            model_name="dref",
-            name="is_published",
+            model_name='dref',
+            name='is_published',
+        ),
+        migrations.RenameField(
+            model_name='dref',
+            old_name='original_language',
+            new_name='starting_language',
         ),
         migrations.RemoveField(
-            model_name="dreffinalreport",
-            name="is_published",
+            model_name='dreffinalreport',
+            name='is_published',
+        ),
+        migrations.RenameField(
+            model_name='dreffinalreport',
+            old_name='original_language',
+            new_name='starting_language',
         ),
         migrations.RemoveField(
-            model_name="drefoperationalupdate",
-            name="is_published",
+            model_name='drefoperationalupdate',
+            name='is_published',
+        ),
+        migrations.RenameField(
+            model_name='drefoperationalupdate',
+            old_name='original_language',
+            new_name='starting_language',
+        ),
+        migrations.AlterField(
+            model_name='dref',
+            name='starting_language',
+            field=models.CharField(blank=True, help_text='The language in which this record was first created.', null=True, verbose_name='Starting language'),
+        ),
+        migrations.AlterField(
+            model_name='dreffinalreport',
+            name='starting_language',
+            field=models.CharField(blank=True, help_text='The language in which this record was first created.', null=True, verbose_name='Starting language'),
+        ),
+        migrations.AlterField(
+            model_name='drefoperationalupdate',
+            name='starting_language',
+            field=models.CharField(blank=True, help_text='The language in which this record was first created.', null=True, verbose_name='Starting language'),
         ),
-    migrations.RunPython(migrate_approved_status_to_new_value, reverse_code=migrations.RunPython.noop),
     ]

dref/migrations/0086_alter_dref_status_alter_dreffinalreport_status_and_more.py

@@ -266,9 +266,11 @@ class DisasterCategory(models.IntegerChoices):
     class Status(models.IntegerChoices):
         DRAFT = 1, _("Draft")
         """Draft: Initial stage content is being created and is not ready for review."""
-        FINALIZED = 2, _("Finalized")
+        FINALIZING = 2, _("Finalizing")
+        """Finalizing: Content is in the translation process from the original language into English."""
+        FINALIZED = 3, _("Finalized")
         """Finalized: Translation is completed, content is ready for review, and updates to the original language are locked."""
-        APPROVED = 3, _("Approved")
+        APPROVED = 4, _("Approved")
         """Approved: The content has been reviewed, accepted, and is ready for use."""
 
     created_at = models.DateTimeField(verbose_name=_("created at"), auto_now_add=True)

dref/migrations/0087_remove_dref_original_language_and_more.py

@@ -472,6 +472,8 @@ def get_dref_access_user_list(self, obj) -> List[int] | None:
     def validate(self, data):
         event_date = data.get("event_date")
         operation_timeframe = data.get("operation_timeframe")
+        if self.instance and self.instance.status == Dref.Status.FINALIZING:
+            raise serializers.ValidationError(gettext("Cannot be updated while the translation is in progress"))
         is_assessment_report = data.get("is_assessment_report")
         if event_date and data["type_of_onset"] not in [Dref.OnsetType.SLOW, Dref.OnsetType.SUDDEN]:
             raise serializers.ValidationError(
@@ -746,6 +748,8 @@ class Meta:
 
     def validate(self, data):
         dref = data.get("dref")
+        if self.instance and self.instance.status == Dref.Status.FINALIZING:
+            raise serializers.ValidationError(gettext("Cannot be updated while the translation is in progress"))
         if not self.instance and dref:
             if dref.status != Dref.Status.APPROVED:
                 raise serializers.ValidationError(gettext("Can't create Operational Update for not approved %s dref." % dref.id))
@@ -789,17 +793,13 @@ def validate_images_file(self, images):
     def create(self, validated_data):
         dref = validated_data["dref"]
         current_language = get_language()
+        stating_langauge = validated_data.get("starting_language")
         valid_languages = [dref.starting_language, dref.translation_module_original_language]
-        # Check request language
-        if current_language not in valid_languages:
+        if current_language != stating_langauge:
+            raise serializers.ValidationError(gettext("Starting language does not match the expected language."))
+        if stating_langauge not in valid_languages:
             raise serializers.ValidationError(
-                gettext(f"Language must be either '{valid_languages[0]}' or '{valid_languages[1]}'.")
-            )
-        # Check payload language
-        language = validated_data.get("starting_language")
-        if language not in valid_languages:
-            raise serializers.ValidationError(
-                gettext(f"Language must be either '{valid_languages[0]}' or '{valid_languages[1]}'.")
+                gettext(f"Invalid starting language. Supported options are '{valid_languages[0]}' and '{valid_languages[1]}'.")
             )
         dref_operational_update = DrefOperationalUpdate.objects.filter(dref=dref).order_by("-operational_update_number").first()
         validated_data["created_by"] = self.context["request"].user
@@ -1147,6 +1147,8 @@ class Meta:
 
     def validate(self, data):
         dref = data.get("dref")
+        if self.instance and self.instance.status == Dref.Status.FINALIZING:
+            raise serializers.ValidationError(gettext("Cannot be updated while the translation is in progress"))
         # Check if dref is published and operational_update associated with it is also published
         if not self.instance and dref:
             if dref.status != Dref.Status.APPROVED:
@@ -1248,18 +1250,13 @@ def create(self, validated_data):
         # else copy from dref
         dref = validated_data["dref"]
         current_language = get_language()
+        stating_langauge = validated_data.get("starting_language")
         valid_languages = [dref.starting_language, dref.translation_module_original_language]
-        # Check request language
-        if current_language not in valid_languages:
-            raise serializers.ValidationError(
-                gettext(f"Language must be either '{valid_languages[0]}' or '{valid_languages[1]}'.")
-            )
-
-        # Check payload language
-        language = validated_data.get("starting_language")
-        if language not in valid_languages:
+        if current_language != stating_langauge:
+            raise serializers.ValidationError(gettext("Starting language does not match the expected language."))
+        if stating_langauge not in valid_languages:
             raise serializers.ValidationError(
-                gettext(f"Language must be either '{valid_languages[0]}' or '{valid_languages[1]}'.")
+                gettext(f"Invalid starting language. Supported options are '{valid_languages[0]}' and '{valid_languages[1]}'.")
             )
         dref_operational_update = (
             DrefOperationalUpdate.objects.filter(dref=dref, status=Dref.Status.APPROVED)

dref/models.py

@@ -1,11 +1,18 @@
+import logging
+
 from celery import shared_task
+from django.apps import apps
 from django.template.loader import render_to_string
 
+from api.utils import get_model_name
+from lang.tasks import translate_model_fields
 from notifications.notification import send_notification
 
 from .models import Dref
 from .utils import get_email_context
 
+logger = logging.getLogger(__name__)
+
 
 @shared_task
 def send_dref_email(dref_id, users_emails, new_or_updated=""):
@@ -20,3 +27,64 @@ def send_dref_email(dref_id, users_emails, new_or_updated=""):
 
     send_notification(email_subject, users_emails, email_body, email_type)
     return email_context
+
+
+@shared_task
+def process_translation(model_name, instance_pk):
+    """
+    Task to translate  model instance and its related objects
+    """
+    instance = None
+    try:
+        model = apps.get_model(model_name)
+        instance = model.objects.get(pk=instance_pk)
+        translate_model_fields(model_name, instance_pk)
+        _translate_related_objects(instance)
+        instance.status = Dref.Status.FINALIZED
+        instance.translation_module_original_language = "en"
+        instance.save(update_fields=["status", "translation_module_original_language"])
+        logger.info(f"Successfully finalized {model_name} ID: {instance_pk}")
+    except Exception as exc:
+        if instance is not None:
+            instance.status = Dref.Status.DRAFT
+            instance.save(update_fields=["status"])
+        logger.error(f"Translation failed for {model_name} ID {instance_pk}: {str(exc)}")
+        raise exc
+
+
+def _translate_related_objects(instance, visited=None):
+    if visited is None:
+        visited = set()
+
+    instance_id = id(instance)
+    if instance_id in visited:
+        return
+    visited.add(instance_id)
+
+    for field in instance._meta.get_fields():
+        if not field.is_relation or field.auto_created:
+            continue
+
+        try:
+            related_value = getattr(instance, field.name, None)
+            if related_value is None:
+                continue
+
+            # Handle related objects
+            if not field.many_to_many:
+                if hasattr(related_value, "translation_module_original_language"):
+                    model_name = get_model_name(type(related_value))
+                    translate_model_fields(model_name, related_value.pk)
+                    _translate_related_objects(related_value, visited)
+
+            # Handle multiple related objects
+            else:
+                for related_obj in related_value.all():
+                    if hasattr(related_obj, "translation_module_original_language"):
+                        model_name = get_model_name(type(related_obj))
+                        translate_model_fields(model_name, related_obj.pk)
+                        _translate_related_objects(related_obj, visited)
+
+        except Exception as e:
+            logger.warning(f"Error processing field {field.name}: {e}")
+            continue