feat(dref): Add test cases for new final report changes

Author: susilnem

dref/serializers.py

@@ -1232,6 +1232,16 @@ def create(self, validated_data):
             DrefOperationalUpdate.objects.filter(dref=dref, is_published=True).order_by("-operational_update_number").first()
         )
         validated_data["created_by"] = self.context["request"].user
+        # NOTE: Checks and common fields for the new dref final reports of new dref imminents
+        if dref.type_of_dref == Dref.DrefType.IMMINENT and dref.is_dref_imminent_v2:
+            validated_data["is_dref_imminent_v2"] = True
+            validated_data["sub_total_cost"] = dref.sub_total_cost
+            validated_data["surge_deployment_cost"] = dref.surge_deployment_cost
+            validated_data["surge_deployment_expenditure_cost"] = dref.surge_deployment_cost
+            validated_data["indirect_cost"] = dref.indirect_cost
+            validated_data["indirect_expenditure_cost"] = dref.indirect_cost
+            validated_data["total_cost"] = dref.total_cost
+
         if dref_operational_update:
             validated_data["title"] = dref_operational_update.title
             validated_data["title_prefix"] = dref_operational_update.title_prefix
@@ -1360,6 +1370,8 @@ def create(self, validated_data):
             dref_final_report.risk_security.add(*dref_operational_update.risk_security.all())
             dref_final_report.users.add(*dref_operational_update.users.all())
             dref_final_report.source_information.add(*dref_operational_update.source_information.all())
+            if dref_final_report.is_dref_imminent_v2:
+                dref_final_report.proposed_action.add(*dref.proposed_action.all())
         else:
             validated_data["title"] = dref.title
             validated_data["title_prefix"] = dref.title_prefix
@@ -1456,15 +1468,6 @@ def create(self, validated_data):
                 raise serializers.ValidationError(
                     gettext("Can't create final report for dref type %s" % Dref.DrefType.LOAN.label)
                 )
-            # NOTE: Checks for the new dref final reports of new dref imminents
-            if validated_data["type_of_dref"] == Dref.DrefType.IMMINENT and dref.is_dref_imminent_v2:
-                validated_data["is_dref_imminent_v2"] = True
-                validated_data["sub_total_cost"] = dref.sub_total_cost
-                validated_data["surge_deployment_cost"] = dref.surge_deployment_cost
-                validated_data["surge_deployment_expenditure_cost"] = dref.surge_deployment_cost
-                validated_data["indirect_cost"] = dref.indirect_cost
-                validated_data["indirect_expenditure_cost"] = dref.indirect_cost
-                validated_data["total_cost"] = dref.total_cost
 
             # NOTE: Checks for the new dref final reports of new dref imminents
             if validated_data["type_of_dref"] == Dref.DrefType.IMMINENT and dref.is_dref_imminent_v2:

dref/test_views.py

@@ -1640,8 +1640,10 @@ def test_dref_imminent_v2_final_report(self):
             is_published=True,
             is_dref_imminent_v2=True,
             sub_total_cost=75000,
-            indirect_cost=5000,
-            total_cost=80000,
+            indirect_cost=5800,
+            is_surge_personnel_deployed=True,
+            surge_deployment_cost=10000,
+            total_cost=90800,
         )
         dref1.proposed_action.set([proposed_action_1, proposed_action_2])
         url = "/api/v2/dref-final-report/"
@@ -1663,11 +1665,15 @@ def test_dref_imminent_v2_final_report(self):
                 response.data["sub_total_cost"],
                 response.data["indirect_cost"],
                 response.data["total_cost"],
+                response.data["surge_deployment_expenditure_cost"],
+                response.data["indirect_expenditure_cost"],
             },
             {
                 dref1.sub_total_cost,
                 dref1.indirect_cost,
                 dref1.total_cost,
+                dref1.surge_deployment_cost,
+                dref1.indirect_cost,
             },
         )
 
@@ -1688,8 +1694,8 @@ def test_dref_imminent_v2_final_report(self):
             ],
             "sub_total_expenditure_cost": 55000,
             "surge_deployment_expenditure_cost": 10000,
-            "indirect_expenditure_cost": 5000,
-            "total_expenditure_cost": 60000,
+            "indirect_expenditure_cost": 5800,
+            "total_expenditure_cost": 70800,
         }
         url = f"/api/v2/dref-final-report/{response.data['id']}/"
         response = self.client.patch(url, data=data)
@@ -1761,6 +1767,27 @@ def test_dref_imminent_v2_final_report(self):
         self.assert_201(response)
         self.assertEqual(response.data["type_of_dref"], Dref.DrefType.IMMINENT)
 
+        # Update existing dref final report
+        url = f"/api/v2/dref-final-report/{response.data['id']}/"
+        data = {
+            "title": "Old Title",
+            "modified_at": datetime.now(),
+        }
+        response = self.client.patch(url, data=data)
+        self.assert_200(response)
+        self.assertEqual(
+            {
+                response.data["title"],
+                response.data["type_of_dref"],
+                response.data["is_dref_imminent_v2"],
+            },
+            {
+                data["title"],
+                Dref.DrefType.IMMINENT,
+                False,  # is_dref_imminent_v2 should be False for existing Dref of type IMMINENT
+            },
+        )
+
 
 User = get_user_model()