Skip to content

Commit 543be49

Browse files
Merge pull request #1616 from IFRCGo/fix/1613-timeout-surgealert-all-csv
Fix timeout for Export All SurgeAlerts
2 parents 2db66c7 + 6a32b5b commit 543be49

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

notifications/drf_views.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,9 @@ def get_queryset(self):
4242
limit = 14 # days
4343
cond1 = Q(is_stood_down=True)
4444
cond2 = Q(end__lt=datetime.utcnow().replace(tzinfo=timezone.utc)-timedelta(days=limit))
45-
return SurgeAlert.objects.exclude(cond1 & cond2)
45+
return super().get_queryset().\
46+
select_related('country').\
47+
exclude(cond1 & cond2) # 'event' inclusion ^ to _related needs frontend change, otherwise the Position column shows garbage in /alerts/all
4648

4749

4850
class SubscriptionViewset(viewsets.ModelViewSet):

notifications/serializers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
from rest_framework import serializers
22

3-
from api.serializers import MiniEventSerializer, ListEventSerializer, MiniCountrySerializer
3+
from api.serializers import MiniEventSerializer, SurgeEventSerializer, MiniCountrySerializer
44
from lang.serializers import ModelSerializer
55

66
from .models import SurgeAlert, Subscription
77
from deployments.serializers import MolnixTagSerializer
88

99

1010
class SurgeAlertSerializer(ModelSerializer):
11-
event = ListEventSerializer()
11+
event = SurgeEventSerializer()
1212
country = MiniCountrySerializer()
1313
atype_display = serializers.CharField(source='get_atype_display', read_only=True)
1414
category_display = serializers.CharField(source='get_category_display', read_only=True)

0 commit comments

Comments
 (0)