Skip to content

Commit 7ff180d

Browse files
Add ordering to form-component ratings.
1 parent 38d66e2 commit 7ff180d

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,12 @@ jobs:
4848
cp .env-sample .env &&
4949
docker compose run --rm serve ls
5050
51-
# NOTE : Uncomment this before merging this to develop after running make migrations.
52-
# - name: 🕮 Validate if there are no pending django migrations.
53-
# run: |
54-
# docker compose run --rm serve ./manage.py makemigrations --check --dry-run || {
55-
# echo 'There are some changes to be reflected in the migration. Make sure to run makemigrations';
56-
# exit 1;
57-
# }
51+
- name: 🕮 Validate if there are no pending django migrations.
52+
run: |
53+
docker compose run --rm serve ./manage.py makemigrations --check --dry-run || {
54+
echo 'There are some changes to be reflected in the migration. Make sure to run makemigrations';
55+
exit 1;
56+
}
5857
5958
- name: 🕮 Validate SentryMonitor config
6059
run: |

per/drf_views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,7 @@ def get(self, request, version=None):
543543
return response.Response(
544544
PerOptionsSerializer(
545545
dict(
546-
componentratings=PerComponentRating.objects.all(),
546+
componentratings=PerComponentRating.objects.all().order_by("value"),
547547
answers=FormAnswer.objects.all(),
548548
overviewassessmenttypes=AssessmentType.objects.all(),
549549
)

0 commit comments

Comments
 (0)