fix(local-units): remove other profiles field from and add mixin

Author: shreeyash07

local_units/serializers.py

@@ -107,7 +107,9 @@ class Meta:
         fields = "__all__"
 
 
-class OtherProfileSerializer(serializers.ModelSerializer):
+class OtherProfileSerializer(NestedCreateMixin, NestedUpdateMixin, serializers.ModelSerializer):
+    id = serializers.IntegerField(required=False)
+
     class Meta:
         model = OtherProfile
         fields = "__all__"
@@ -154,10 +156,9 @@ class HealthDataSerializer(
     professional_training_facilities_details = ProfessionalTrainingFacilitySerializer(
         source="professional_training_facilities", many=True, read_only=True
     )
-    other_profiles_details = OtherProfileSerializer(
-        source="other_profiles",
+    other_profiles = OtherProfileSerializer(
         many=True,
-        read_only=True,
+        required=False,
     )
     modified_by_details = LocalUnitMiniUserSerializer(source="modified_by", read_only=True)
     created_by_details = LocalUnitMiniUserSerializer(source="created_by", read_only=True)
@@ -553,7 +554,6 @@ class LocalUnitOptionsSerializer(serializers.Serializer):
     professional_training_facilities = ProfessionalTrainingFacilitySerializer(many=True)
     general_medical_services = GeneralMedicalServiceSerializer(many=True)
     specialized_medical_beyond_primary_level = SpecializedMedicalServiceSerializer(many=True)
-    other_profiles = OtherProfileSerializer(many=True)
 
 
 class MiniDelegationOfficeSerializer(serializers.ModelSerializer):

local_units/test_views.py

@@ -34,7 +34,6 @@
     LocalUnitChangeRequest,
     LocalUnitLevel,
     LocalUnitType,
-    OtherProfile,
     PrimaryHCC,
     ProfessionalTrainingFacility,
     SpecializedMedicalService,
@@ -525,7 +524,6 @@ def test_create_update_local_unit_health(self):
         functionality = Functionality.objects.create(code=1, name="Code 1")
         health_facility_type = FacilityType.objects.create(code=1, name="Code 1")
         primary_health_care_center = PrimaryHCC.objects.create(code=1, name="Code 1")
-        other_profiles = OtherProfile.objects.create(number=1, position="test")
         data = {
             "local_branch_name": "Silele Red Cross Clinic, Sigombeni Red Cross Clinic & Mahwalala Red Cross Clinic",
             "english_branch_name": None,
@@ -578,7 +576,10 @@ def test_create_update_local_unit_health(self):
                 "nursing_aid": 0,
                 "midwife": 9,
                 "other_medical_heal": True,
-                "other_profiles": [other_profiles.id],
+                "other_profiles": [
+                    {"number": 2, "position": "Nurse"},
+                    {"number": 3, "position": "Doctor"},
+                ],
                 "feedback": "first question of initial question did not provide for the option to write the name of the NS. It is written LRC yet it should allow Baphalali Eswatini Red Cross Society (BERCS) to be inscribed in the box.",  # noqa: E501
                 "affiliation": affiliation.id,
                 "functionality": functionality.id,