Removed html form form the browsable api

Author: Rup-Narayan-Rajbanshi

eap/serializers.py

@@ -8,6 +8,7 @@
     CountrySerializer,
     MiniDistrictSerializer,
 )
+from api.models import District
 
 from eap.models import (
     EAP,
@@ -60,7 +61,7 @@ class Meta:
         read_only_fields = ('early_action',)
 
 
-class PrioritizedRiskSerializer(serializers.ModelSerializer): 
+class PrioritizedRiskSerializer(serializers.ModelSerializer):
     class Meta:
         model = PrioritizedRisk
         fields = ('__all__')
@@ -118,74 +119,26 @@ class EAPSerializer(
 
     class Meta:
         model = EAP
-        fields = [
-            "id",
-            "created_at",
-            "modified_at",
-            "eap_number",
-            "approval_date",
-            "status",
-            "operational_timeframe",
-            "lead_time",
-            "eap_timeframe",
-            "num_of_people",
-            "total_budget",
-            "readiness_budget",
-            "pre_positioning_budget",
-            "early_action_budget",
-            "trigger_statement",
-            "overview",
-            "originator_name",
-            "originator_title",
-            "originator_email",
-            "originator_phone",
-            "nsc_name",
-            "nsc_title",
-            "nsc_email",
-            "nsc_phone",
-            "ifrc_focal_name",
-            "ifrc_focal_title",
-            "ifrc_focal_email",
-            "ifrc_focal_phone",
-            "created_by",
-            "created_by_details",
-            "modified_by",
-            "modified_by_details",
-            "country",
-            "country_details",
-            # "districts",
-            "districts_details",
-            "disaster_type",
-            "hazard_type_details",
-            "status_display",
-            "references",
-            "partners",
-            "documents",
-            "documents_details",
-            "early_actions",
-        ]
-
-    def validate(self, validated_data):
-        if self.partial:
-            return validated_data
-        districts = validated_data.get('districts', None)
-        if districts:
+        fields = ('__all__')
+
+    def validate(self, data):
+        if 'districts' in data:
+            districts = data.get('districts') or []
+            country = data.get('country')
             for district in districts:
-                if district.country != validated_data['country']:
+                if district.country != country:
                     raise serializers.ValidationError({
-                        'district': ugettext('Different districts found for given country')
+                        'districts': ugettext('Different districts found for given country')
                     })
-        return validated_data
+        return data
 
     def create(self, validated_data):
         validated_data['created_by'] = self.context['request'].user
-        eap = super().create(validated_data)
-        return eap
+        return super().create(validated_data)
 
     def update(self, instance, validated_data):
         validated_data['modified_by'] = self.context['request'].user
-        eap = super().update(instance, validated_data)
-        return eap
+        return super().update(instance, validated_data)
 
 
 class EAPActivationSerializer(serializers.ModelSerializer):

eap/views.py

@@ -1,5 +1,4 @@
 # Create your views here.
-
 from rest_framework import (
     views,
     viewsets,
@@ -57,16 +56,16 @@ class EAPViewSet(viewsets.ModelViewSet):
     permission_classes = [permissions.IsAuthenticated]
 
     def get_queryset(self):
-        # return EAP.objects.all()
-        return EAP.objects.all().order_by(
+        result = EAP.objects.all().order_by(
             '-created_at'
         ).select_related(
             'country',
             'created_by',
-            # 'modified_by',
+            'modified_by',
             'disaster_type',
         ).prefetch_related(
             'districts',
+            'districts__country',
             'documents',
             'early_actions',
             'early_actions__action',
@@ -75,6 +74,7 @@ def get_queryset(self):
             'eap_reference',
             'eap_partner',
         )
+        return result
 
 
 class EAPActivationReportViewSet(viewsets.ModelViewSet):

main/settings.py

@@ -176,7 +176,8 @@
     ),
     'DEFAULT_RENDERER_CLASSES': (
         'rest_framework.renderers.JSONRenderer',
-        'rest_framework.renderers.BrowsableAPIRenderer',
+        # 'rest_framework.renderers.BrowsableAPIRenderer', # it is comment out to reduce load time in browsable api
+        'main.utils.BrowsableAPIRendererWithRawForms',  # it is added to reduce load time in browsable api
         'rest_framework_csv.renderers.PaginatedCSVRenderer',
     ),
     'DEFAULT_SCHEMA_CLASS': 'rest_framework.schemas.coreapi.AutoSchema',

main/utils.py

@@ -1,5 +1,7 @@
 from collections import defaultdict
 
+from rest_framework.renderers import BrowsableAPIRenderer
+
 
 def is_tableau(request):
     """ Checking the request for the 'tableau' parameter
@@ -24,3 +26,21 @@ def get_merged_items_by_fields(items, fields, seperator=', '):
         field: seperator.join(data[field])
         for field in fields
     }
+
+
+class BrowsableAPIRendererWithRawForms(BrowsableAPIRenderer):  # It is done to reduce load time in browsable api.
+    """
+    Renders the browsable api, but excludes the normal forms.
+    Only show raw form.
+    """
+
+    def get_context(self, *args, **kwargs):
+        ctx = super().get_context(*args, **kwargs)
+        ctx['post_form'] = None
+        return ctx
+
+    def get_rendered_html_form(self, data, view, method, request):
+        """Why render _any_ forms at all. This method should return
+        rendered HTML, so let's simply return an empty string.
+        """
+        return ""