Skip to content

Commit 9012be4

Browse files
committed
Merge branch 'develop' – N+1 fix for SituationReportViewset
2 parents 9950bbe + 8f91bcb commit 9012be4

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

api/drf_views.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,10 @@
5050
SituationReportFilter,
5151
UserFilterSet,
5252
)
53-
from api.visibility_class import ReadOnlyVisibilityViewsetMixin
53+
from api.visibility_class import (
54+
ReadOnlyVisibilityViewset,
55+
ReadOnlyVisibilityViewsetMixin,
56+
)
5457
from country_plan.models import CountryPlan
5558
from databank.serializers import CountryOverviewSerializer
5659
from deployments.models import Personnel
@@ -148,7 +151,6 @@
148151
UserSerializer,
149152
)
150153
from .utils import is_user_ifrc
151-
from .visibility_class import ReadOnlyVisibilityViewset
152154

153155

154156
class DeploymentsByEventViewset(viewsets.ReadOnlyModelViewSet):
@@ -720,7 +722,8 @@ class SituationReportTypeViewset(viewsets.ReadOnlyModelViewSet):
720722
search_fields = ("type",) # for /docs
721723

722724

723-
class SituationReportViewset(ReadOnlyVisibilityViewset):
725+
class SituationReportViewset(ReadOnlyVisibilityViewsetMixin, viewsets.ReadOnlyModelViewSet):
726+
queryset = SituationReport.objects.select_related("type")
724727
authentication_classes = (TokenAuthentication,)
725728
serializer_class = SituationReportSerializer
726729
ordering_fields = (

0 commit comments

Comments
 (0)