fix(template): update local unit email template

sudip-khanal · susilnem · commit a714f3b3ded7 · 2025-08-25T15:59:51.000+05:45
diff --git a/local_units/serializers.py b/local_units/serializers.py
@@ -446,6 +446,7 @@ class PrivateLocalUnitSerializer(serializers.ModelSerializer):
     status_details = serializers.CharField(source="get_status_display", read_only=True)
     modified_by_details = LocalUnitMiniUserSerializer(source="modified_by", read_only=True)
     is_locked = serializers.BooleanField(read_only=True)
+    update_reason_overview = serializers.CharField(read_only=True)
 
     class Meta:
         model = LocalUnit
@@ -473,6 +474,7 @@ class Meta:
             "is_locked",
             "is_new_local_unit",
             "bulk_upload",
+            "update_reason_overview",
         )
 
     def get_location_geojson(self, unit) -> dict:
diff --git a/local_units/tasks.py b/local_units/tasks.py
@@ -45,6 +45,9 @@ def send_local_unit_email(local_unit_id: int, new: bool = True):
 
     for user in users:
         # NOTE: Adding the validator email to the context
+        if not user.email:
+            logger.warning(f"Email address not found for validator: {user.get_full_name()}.")
+            return None
         email_context["validator_email"] = user.email
         email_context["full_name"] = user.get_full_name()
         email_body = render_to_string("email/local_units/local_unit.html", email_context)
@@ -58,6 +61,14 @@ def send_validate_success_email(local_unit_id: int, message: str = ""):
 
     instance = LocalUnit.objects.get(id=local_unit_id)
     user = instance.created_by
+    if not user:
+        logger.warning(f"Email not sent for Local Unit:{local_unit_id} because creator is unknown.")
+        return None
+    elif not user.email:
+        logger.warning(
+            f"Email not sent for Local Unit:{local_unit_id} because creator: {user.get_full_name()} has no email address."
+        )
+        return None
     email_context = get_email_context(instance)
     email_context["full_name"] = user.get_full_name()
     email_context["validate_success"] = True
@@ -76,6 +87,14 @@ def send_revert_email(local_unit_id: int, change_request_id: int):
     instance = LocalUnit.objects.get(id=local_unit_id)
     change_request_instance = LocalUnitChangeRequest.objects.get(id=change_request_id)
     user = instance.created_by
+    if not user:
+        logger.warning(f"Email not sent for Local Unit:{local_unit_id} because creator is unknown.")
+        return None
+    elif not user.email:
+        logger.warning(
+            f"Email not sent for Local Unit:{local_unit_id} because creator: {user.get_full_name()} has no email address."
+        )
+        return None
     email_context = get_email_context(instance)
     email_context["full_name"] = user.get_full_name()
     email_context["revert_reason"] = change_request_instance.rejected_reason
@@ -94,6 +113,15 @@ def send_deprecate_email(local_unit_id: int):
 
     instance = LocalUnit.objects.get(id=local_unit_id)
     user = instance.created_by
+    if not user:
+        logger.warning(f"Email not sent for Local Unit:{local_unit_id} because creator is unknown.")
+        return None
+    elif not user.email:
+        logger.warning(
+            f"Email not sent for Local Unit:{local_unit_id} because creator: {user.get_full_name()} has no email address."
+        )
+        return None
+
     email_context = get_email_context(instance)
     email_context["full_name"] = user.get_full_name()
     email_context["deprecate_local_unit"] = True
diff --git a/local_units/utils.py b/local_units/utils.py
@@ -14,7 +14,10 @@ def get_email_context(instance):
     email_context = {
         "id": local_unit_data["id"],
         "local_branch_name": local_unit_data["local_branch_name"],
-        "frontend_url": settings.FRONTEND_URL,
+        "country": local_unit_data["country_details"]["name"],
+        "country_id": local_unit_data["country_details"]["id"],
+        "update_reason_overview": local_unit_data["update_reason_overview"],
+        "frontend_url": settings.GO_WEB_URL,
     }
     return email_context
 
diff --git a/notifications/templates/design/foot1.html b/notifications/templates/design/foot1.html
@@ -8,11 +8,11 @@
                       <table width="100%" border="0" cellspacing="0" cellpadding="0">
                         <tr>
                           <td class="text-default td-smaller-font-style text-right pl-10 pr-10" style="color: #000000;font-family:'Lato', Arial, sans-serif;border-right:1px solid #000;font-size: 16px;text-align: right;padding-left: 10px;padding-right: 10px;">
-                            <a href="https://go.ifrc.org/login" target="_blank" class="link" style="font-family: 'Lato', Arial, sans-serif;text-decoration: underline;color: #000;">Login to IFRC GO</a>
+                            <a href="{{ frontend_url }}/login" target="_blank" class="link" style="font-family: 'Lato', Arial, sans-serif;text-decoration: underline;color: #000;">Login to IFRC GO</a>
                           </td>
 {% if not hide_preferences %}
                           <td class="text-default td-smaller-font-style pl-10 pr-10" style="color: #000000;font-family:'Lato', Arial, sans-serif;font-size: 16px;padding-left: 10px;padding-right: 10px;">
-                            <a href="https://go.ifrc.org/account#notifications" target="_blank" class="link" style="font-family: 'Lato', Arial, sans-serif;text-decoration: underline;color: #000;">Unsubscribe</a>
+                           <a href="https://go.ifrc.org/account#notifications" target="_blank" class="link" style="font-family: 'Lato', Arial, sans-serif;text-decoration: underline;color: #000;">Unsubscribe</a>
                           </td>
 {% endif %}
                         </tr>
diff --git a/notifications/templates/design/foot2.html b/notifications/templates/design/foot2.html
@@ -1,21 +1,19 @@
-<!-- Footer -->
+          <!-- Footer -->
           <table width="100%" border="0" cellspacing="0" cellpadding="0" bgcolor="#ffffff">
             <tr>
-              <td valign="top" align="center" class="pt-50 pb-50" style="padding-top: 50px; padding-bottom: 50px;">
+              <td valign="top" align="center" class="pt-50 pb-50">
                 <table width="650" border="0" cellspacing="0" cellpadding="0" class="mobile-shell">
                   <tr>
                     <td class="td td-shell" style="padding: 0;margin: 0;">
                       <table width="100%" border="0" cellspacing="0" cellpadding="0">
                         <tr>
-                          <td class="text-default text-right pr-10" style="padding-right: 10px;border-right:1px solid #000;text-align: right;font-style: normal;font-weight: 300;font-size: 12px;line-height: 18px">
-                            <a href="https://go.ifrc.org/login" target="_blank" class="link" style="font-family: Poppins, Arial, sans-serif;text-decoration: underline;color: #000;">Login to IFRC GO</a>
+                          <td class="text-default td-smaller-font-style text-right pl-10 pr-10" style="color: #000000;font-family:'Lato', Arial, sans-serif;border-right:1px solid #000;font-size: 16px;text-align: right;padding-left: 10px;padding-right: 10px;">
+                            <a href="{{ frontend_url }}/login" target="_blank" class="link" style="font-family: 'Lato', Arial, sans-serif;text-decoration: underline;color: #000;">Login to IFRC GO</a>
                           </td>
 {% if not hide_preferences %}
-{% for record in records|slice:":1" %}
-                          <td class="text-default pl-10" style="padding-left: 10px;font-style: normal;font-weight: 300;font-size: 12px;line-height: 18px">
-                            <a href="https://{{ record.frontend_url }}/account#notifications" target="_blank" class="link" style="font-family: Poppins, Arial, sans-serif;text-decoration: underline;color: #000;">Unsubscribe</a>
+                          <td class="text-default td-smaller-font-style pl-10 pr-10" style="color: #000000;font-family:'Lato', Arial, sans-serif;font-size: 16px;padding-left: 10px;padding-right: 10px;">
+                           <a href="{{ frontend_url }}/account#notifications" target="_blank" class="link" style="font-family: 'Lato', Arial, sans-serif;text-decoration: underline;color: #000;">Unsubscribe</a>
                           </td>
-{% endfor %}
 {% endif %}
                         </tr>
                       </table>
diff --git a/notifications/templates/email/local_units/local_unit.html b/notifications/templates/email/local_units/local_unit.html
@@ -9,49 +9,54 @@ <h3>Dear {{full_name}}</h3>
     <tr>
         {% if new_local_unit %}
         <td align="center" class="pb-30">
-            A new local unit "{{local_branch_name}}" has been added and is awaiting your validation. Kindly review the information and validate or delete as necessary.
+           A new local unit "{{local_branch_name}}" in {{country}} has been added and is awaiting your validation. Please review the details and validate or delete as necessary.
+           You can view the new local unit <a href="{{ frontend_url }}/countries/{{country_id}}/ns-overview/context-and-structure" target="_blank" class="link" style="font-family: 'Lato', Arial, sans-serif;text-decoration: underline;color: #000;">here.</a>
         </td>
         {% endif %}
 
         {% if update_local_unit %}
         <td align="center" class="pb-30">
-            The local unit "{{local_branch_name}}" has been updated and is awaiting your validation. Kindly review the information and validate or delete as necessary.
+            The local unit "{{local_branch_name}}" in {{country}} has been updated. Reason:"{{update_reason_overview}}" and is awaiting your validation. Kindly review the information and validate or delete as necessary.
+            You can view the updated local unit <a href="{{ frontend_url }}/countries/{{country_id}}/ns-overview/context-and-structure" target="_blank" class="link" style="font-family: 'Lato', Arial, sans-serif;text-decoration: underline;color: #000;">here.</a>
         </td>
         {% endif %}
 
         {% if validate_success %}
         <td align="center" class="pb-30">
-            Your request for the local unit "{{local_branch_name}}" has been successfully validated. The local unit is now visible and marked as validated.
+            Your request for the local unit "{{local_branch_name}}" in {{country}} has been successfully validated. The local unit is now visible and marked as validated.
+            You can view the validated local unit <a href="{{ frontend_url }}/countries/{{country_id}}/ns-overview/context-and-structure" target="_blank" class="link" style="font-family: 'Lato', Arial, sans-serif;text-decoration: underline;color: #000;">here.</a>
         </td>
         {% endif %}
 
         {% if revert_reason %}
         <td align="center" class="pb-30">
-            Your local unit "{{local_branch_name}}" has been reverted. {{revert_reason}}. Please review and resubmit if applicable.
+            Your local unit "{{local_branch_name}}" in {{country}} has been reverted. Reason: {{revert_reason}}. Please review and resubmit if applicable.
         </td>
         {% endif %}
 
         {% if deprecate_local_unit %}
         <td align="center" class="pb-30">
-            Your local unit "{{local_branch_name}}" has been deprecated. {{deprecate_reason}}. Please contact the administrator for more information.
+            Your local unit "{{local_branch_name}}" in {{country}} has been deprecated. Reason: {{deprecate_reason}}. Please contact the administrator for more information.
         </td>
         {% endif %}
 
         {% if is_validator_regional_admin %}
         <td align="center" class="pb-30">
-            The new local unit "{{local_branch_name}}" has been pending validation for over 7 days. Kindly review and validate or delete as necessary.
+            The new local unit "{{local_branch_name}}" in {{country}} has been pending validation for over 7 days. Kindly review and validate or delete as necessary.
+            You can view the new local unit <a href="{{ frontend_url }}/countries/{{country_id}}/ns-overview/context-and-structure" target="_blank" class="link" style="font-family: 'Lato', Arial, sans-serif;text-decoration: underline;color: #000;">here.</a>
         </td>
         {% endif %}
 
         {% if is_validator_global_admin %}
         <td align="center" class="pb-30">
-            The new local unit "{{local_branch_name}}" has been pending validation for over 14 days and requires your attention. Please review and validate
+            The new local unit "{{local_branch_name}}" in {{country}} has been pending validation for over 14 days and requires your attention. Please review and validate
             or delete as necessary.
+            You can view the new local unit <a href="{{ frontend_url }}/countries/{{country_id}}/ns-overview/context-and-structure" target="_blank" class="link" style="font-family: 'Lato', Arial, sans-serif;text-decoration: underline;color: #000;">here.</a>
         </td>
         {% endif %}
 
     </tr>
 </table>
 <p>Thank you for your attention to this matter.</p>
 
-{% include "design/foot1.html" %}
+{% include "design/foot2.html" %}
