Merge pull request #2544 from IFRCGo/feat/add-file-size-limit

 Add file size limit on bulk upload

Author: susilnem

deploy/helm/ifrcgo-helm/values.yaml

@@ -272,9 +272,8 @@ cronjobs:
     schedule: '0 0 * * 0'
   - command: 'ingest_icrc'
     schedule: '0 3 * * 0'
-  # NOTE: Disabling local unit email notification for now 
-  # - command: 'notify_validators'
-  #   schedule: '0 0 * * *'
+  - command: 'notify_validators'
+    schedule: '0 0 * * *'
   # https://github.com/jazzband/django-oauth-toolkit/blob/master/docs/management_commands.rst#cleartokens
   - command: 'oauth_cleartokens'
     schedule: '0 1 * * *'

local_units/management/commands/notify_validators.py

@@ -1,5 +1,6 @@
 from datetime import timedelta
 
+from django.conf import settings
 from django.core.management.base import BaseCommand
 from django.template.loader import render_to_string
 from django.utils import timezone
@@ -21,21 +22,28 @@ class Command(BaseCommand):
     @monitor(monitor_slug=SentryMonitor.NOTIFY_VALIDATORS)
     def handle(self, *args, **options):
         self.stdout.write(self.style.NOTICE("Notifying the validators..."))
-
+        # NOTE: In production use standard email notification time(7days/14days),shorter delays(1day/2days) elsewhere for testing
+        production = settings.GO_ENVIRONMENT == "production"
+        if production:
+            regional_email_notification_days = 7
+            global_email_notification_days = 14
+        else:
+            regional_email_notification_days = 1
+            global_email_notification_days = 2
         # Regional Validators: 14 days
         queryset_for_regional_validators = LocalUnit.objects.filter(
             status__in=[LocalUnit.Status.UNVALIDATED, LocalUnit.Status.PENDING_EDIT_VALIDATION],
             is_deprecated=False,
             last_sent_validator_type=Validator.LOCAL,
-            created_at__lte=timezone.now() - timedelta(days=7),
+            created_at__lte=timezone.now() - timedelta(days=regional_email_notification_days),
         )
 
         # Global Validators: 28 days
         queryset_for_global_validators = LocalUnit.objects.filter(
             status__in=[LocalUnit.Status.UNVALIDATED, LocalUnit.Status.PENDING_EDIT_VALIDATION],
             is_deprecated=False,
             last_sent_validator_type=Validator.REGIONAL,
-            created_at__lte=timezone.now() - timedelta(days=14),
+            created_at__lte=timezone.now() - timedelta(days=global_email_notification_days),
         )
 
         for local_unit in queryset_for_regional_validators:

local_units/serializers.py

@@ -699,6 +699,8 @@ class Meta:
     def validate_file(self, file):
         if not file.name.endswith(".csv"):
             raise serializers.ValidationError(gettext("File must be a CSV file."))
+        if file.size > 10 * 1024 * 1024:
+            raise serializers.ValidationError(gettext("File must be less than 10 MB."))
         return file
 
     def get_file_name(self, obj):

local_units/views.py

@@ -401,6 +401,7 @@ class ExternallyManagedLocalUnitViewSet(
 class LocalUnitBulkUploadViewSet(
     mixins.CreateModelMixin,
     mixins.ListModelMixin,
+    mixins.RetrieveModelMixin,
     viewsets.GenericViewSet,
 ):
     queryset = LocalUnitBulkUpload.objects.select_related("country", "local_unit_type", "triggered_by").order_by("-triggered_at")

main/sentry.py

@@ -128,8 +128,7 @@ class SentryMonitor(models.TextChoices):
     INGEST_NS_DOCUMENT = "ingest_ns_document", "0 0 * * 0"
     INGEST_NS_INITIATIVES = "ingest_ns_initiatives", "0 0 * * 0"
     INGEST_ICRC = "ingest_icrc", "0 3 * * 0"
-    # NOTE: Disabling local unit email notification for now
-    # NOTIFY_VALIDATORS = "notify_validators", "0 0 * * *"
+    NOTIFY_VALIDATORS = "notify_validators", "0 0 * * *"
     OAUTH_CLEARTOKENS = "oauth_cleartokens", "0 1 * * *"
 
     @staticmethod

notifications/templates/email/local_units/local_unit.html

@@ -16,7 +16,7 @@ <h3>Dear {{full_name}}</h3>
 
         {% if update_local_unit %}
         <td align="center" class="pb-30">
-            The local unit "{{local_branch_name}}" in {{country}} has been updated. Reason:"{{update_reason_overview}}" and is awaiting your validation. Kindly review the information and validate or delete as necessary.
+            The local unit "{{local_branch_name}}" in {{country}} has been updated. Reason: {{update_reason_overview}} and is awaiting your validation. Kindly review the information and validate or delete as necessary.
             You can view the updated local unit <a href="{{ frontend_url }}/countries/{{country_id}}/ns-overview/context-and-structure" target="_blank" class="link" style="font-family: 'Lato', Arial, sans-serif;text-decoration: underline;color: #000;">here.</a>
         </td>
         {% endif %}