refactor(dref): refactor dref finalize logic

Author: sudip-khanal

dref/migrations/0084_dref_original_language_and_more.py

@@ -20,6 +20,18 @@ def update_status(apps, schema_editor):
         Model.objects.filter(is_published=True).update(status=4)  # Published → APPROVED
         Model.objects.filter(is_published=False).update(status=1)  # Not published → DRAFT
 
+def update_original_language(apps, schema_editor):
+    """
+    Populate the original_language field with 'en' for all existing records.
+    """
+    models = [
+        "Dref",
+        "DrefOperationalUpdate",
+        "DrefFinalReport",
+    ]
+    for model_name in models:
+        Model = apps.get_model("dref", model_name)
+        Model.objects.update(original_language="en")
 
 class Migration(migrations.Migration):
 
@@ -80,4 +92,5 @@ class Migration(migrations.Migration):
             ),
         ),
         migrations.RunPython(update_status, reverse_code=migrations.RunPython.noop),
+        migrations.RunPython(update_original_language,reverse_code=migrations.RunPython.noop),
     ]

dref/migrations/0085_remove_dref_is_published_and_more.py

@@ -1,37 +1,55 @@
-# Generated by Django 4.2.19 on 2025-09-16 09:13
+# Generated by Django 4.2.19 on 2025-11-05 04:07
+
+from django.db import migrations, models
 
-from django.db import migrations
 
-def migrate_approved_status_to_new_value(apps, schema_editor):
-    """
-    Migrates the 'APPROVED' status from old value (4) to new value (3)
-    """
-    models = [
-        "Dref",
-        "DrefOperationalUpdate",
-        "DrefFinalReport",
-    ]
-    for model_name in models:
-        Model = apps.get_model("dref", model_name)
-        Model.objects.filter(status=4).update(status=3) 
 class Migration(migrations.Migration):
 
     dependencies = [
-        ("dref", "0084_dref_original_language_and_more"),
+        ('dref', '0084_dref_original_language_and_more'),
     ]
 
     operations = [
         migrations.RemoveField(
-            model_name="dref",
-            name="is_published",
+            model_name='dref',
+            name='is_published',
+        ),
+        migrations.RenameField(
+            model_name='dref',
+            old_name='original_language',
+            new_name='starting_language',
         ),
         migrations.RemoveField(
-            model_name="dreffinalreport",
-            name="is_published",
+            model_name='dreffinalreport',
+            name='is_published',
+        ),
+        migrations.RenameField(
+            model_name='dreffinalreport',
+            old_name='original_language',
+            new_name='starting_language',
         ),
         migrations.RemoveField(
-            model_name="drefoperationalupdate",
-            name="is_published",
+            model_name='drefoperationalupdate',
+            name='is_published',
+        ),
+        migrations.RenameField(
+            model_name='drefoperationalupdate',
+            old_name='original_language',
+            new_name='starting_language',
+        ),
+        migrations.AlterField(
+            model_name='dref',
+            name='starting_language',
+            field=models.CharField(blank=True, help_text='The language in which this record was first created.', null=True, verbose_name='Starting language'),
+        ),
+        migrations.AlterField(
+            model_name='dreffinalreport',
+            name='starting_language',
+            field=models.CharField(blank=True, help_text='The language in which this record was first created.', null=True, verbose_name='Starting language'),
+        ),
+        migrations.AlterField(
+            model_name='drefoperationalupdate',
+            name='starting_language',
+            field=models.CharField(blank=True, help_text='The language in which this record was first created.', null=True, verbose_name='Starting language'),
         ),
-    migrations.RunPython(migrate_approved_status_to_new_value, reverse_code=migrations.RunPython.noop),
     ]

dref/migrations/0086_alter_dref_status_alter_dreffinalreport_status_and_more.py

@@ -0,0 +1,73 @@
+# Generated by Django 4.2.19 on 2025-11-05 08:22
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('dref', '0085_remove_dref_is_published_and_more'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='dref',
+            name='addressed_humanitarian_impacts_ar',
+            field=models.TextField(blank=True, help_text=' Which of the expected severe humanitarian impacts of the hazard are your actions addressing?', null=True, verbose_name='Addressed Humanitarian Impacts'),
+        ),
+        migrations.AddField(
+            model_name='dref',
+            name='addressed_humanitarian_impacts_en',
+            field=models.TextField(blank=True, help_text=' Which of the expected severe humanitarian impacts of the hazard are your actions addressing?', null=True, verbose_name='Addressed Humanitarian Impacts'),
+        ),
+        migrations.AddField(
+            model_name='dref',
+            name='addressed_humanitarian_impacts_es',
+            field=models.TextField(blank=True, help_text=' Which of the expected severe humanitarian impacts of the hazard are your actions addressing?', null=True, verbose_name='Addressed Humanitarian Impacts'),
+        ),
+        migrations.AddField(
+            model_name='dref',
+            name='addressed_humanitarian_impacts_fr',
+            field=models.TextField(blank=True, help_text=' Which of the expected severe humanitarian impacts of the hazard are your actions addressing?', null=True, verbose_name='Addressed Humanitarian Impacts'),
+        ),
+        migrations.AddField(
+            model_name='dref',
+            name='hazard_date_and_location_ar',
+            field=models.TextField(blank=True, help_text='When and where is the hazard expected to happen?', null=True, verbose_name='Hazard Date and Location'),
+        ),
+        migrations.AddField(
+            model_name='dref',
+            name='hazard_date_and_location_en',
+            field=models.TextField(blank=True, help_text='When and where is the hazard expected to happen?', null=True, verbose_name='Hazard Date and Location'),
+        ),
+        migrations.AddField(
+            model_name='dref',
+            name='hazard_date_and_location_es',
+            field=models.TextField(blank=True, help_text='When and where is the hazard expected to happen?', null=True, verbose_name='Hazard Date and Location'),
+        ),
+        migrations.AddField(
+            model_name='dref',
+            name='hazard_date_and_location_fr',
+            field=models.TextField(blank=True, help_text='When and where is the hazard expected to happen?', null=True, verbose_name='Hazard Date and Location'),
+        ),
+        migrations.AddField(
+            model_name='dref',
+            name='hazard_vulnerabilities_and_risks_ar',
+            field=models.TextField(blank=True, help_text='Explain the underlying vulnerabilities and risks the hazard poses for at-risk communities?', null=True, verbose_name='Hazard Vulnerabilities and Risks'),
+        ),
+        migrations.AddField(
+            model_name='dref',
+            name='hazard_vulnerabilities_and_risks_en',
+            field=models.TextField(blank=True, help_text='Explain the underlying vulnerabilities and risks the hazard poses for at-risk communities?', null=True, verbose_name='Hazard Vulnerabilities and Risks'),
+        ),
+        migrations.AddField(
+            model_name='dref',
+            name='hazard_vulnerabilities_and_risks_es',
+            field=models.TextField(blank=True, help_text='Explain the underlying vulnerabilities and risks the hazard poses for at-risk communities?', null=True, verbose_name='Hazard Vulnerabilities and Risks'),
+        ),
+        migrations.AddField(
+            model_name='dref',
+            name='hazard_vulnerabilities_and_risks_fr',
+            field=models.TextField(blank=True, help_text='Explain the underlying vulnerabilities and risks the hazard poses for at-risk communities?', null=True, verbose_name='Hazard Vulnerabilities and Risks'),
+        ),
+    ]

dref/migrations/0086_dref_addressed_humanitarian_impacts_ar_and_more.py

@@ -266,9 +266,11 @@ class DisasterCategory(models.IntegerChoices):
     class Status(models.IntegerChoices):
         DRAFT = 1, _("Draft")
         """Draft: Initial stage content is being created and is not ready for review."""
-        FINALIZED = 2, _("Finalized")
+        FINALIZING = 2, _("Finalizing")
+        """Finalizing: Content is in the translation process from the original language into English."""
+        FINALIZED = 3, _("Finalized")
         """Finalized: Translation is completed, content is ready for review, and updates to the original language are locked."""
-        APPROVED = 3, _("Approved")
+        APPROVED = 4, _("Approved")
         """Approved: The content has been reviewed, accepted, and is ready for use."""
 
     created_at = models.DateTimeField(verbose_name=_("created at"), auto_now_add=True)

dref/migrations/0087_remove_dref_original_language_and_more.py

@@ -471,6 +471,8 @@ def get_dref_access_user_list(self, obj) -> List[int] | None:
     def validate(self, data):
         event_date = data.get("event_date")
         operation_timeframe = data.get("operation_timeframe")
+        if self.instance and self.instance.status == Dref.Status.FINALIZING:
+            raise serializers.ValidationError(gettext("Cannot be updated while the translation is in progress"))
         is_assessment_report = data.get("is_assessment_report")
         if event_date and data["type_of_onset"] not in [Dref.OnsetType.SLOW, Dref.OnsetType.SUDDEN]:
             raise serializers.ValidationError(
@@ -745,6 +747,8 @@ class Meta:
 
     def validate(self, data):
         dref = data.get("dref")
+        if self.instance and self.instance.status == Dref.Status.FINALIZING:
+            raise serializers.ValidationError(gettext("Cannot be updated while the translation is in progress"))
         if not self.instance and dref:
             if dref.status != Dref.Status.APPROVED:
                 raise serializers.ValidationError(gettext("Can't create Operational Update for not approved %s dref." % dref.id))
@@ -788,17 +792,13 @@ def validate_images_file(self, images):
     def create(self, validated_data):
         dref = validated_data["dref"]
         current_language = get_language()
+        stating_langauge = validated_data.get("starting_language")
         valid_languages = [dref.starting_language, dref.translation_module_original_language]
-        # Check request language
-        if current_language not in valid_languages:
+        if current_language != stating_langauge:
+            raise serializers.ValidationError(gettext("Starting language does not match the expected language."))
+        if stating_langauge not in valid_languages:
             raise serializers.ValidationError(
-                gettext(f"Language must be either '{valid_languages[0]}' or '{valid_languages[1]}'.")
-            )
-        # Check payload language
-        language = validated_data.get("starting_language")
-        if language not in valid_languages:
-            raise serializers.ValidationError(
-                gettext(f"Language must be either '{valid_languages[0]}' or '{valid_languages[1]}'.")
+                gettext(f"Invalid starting language. Supported options are '{valid_languages[0]}' and '{valid_languages[1]}'.")
             )
         dref_operational_update = DrefOperationalUpdate.objects.filter(dref=dref).order_by("-operational_update_number").first()
         validated_data["created_by"] = self.context["request"].user
@@ -1146,6 +1146,8 @@ class Meta:
 
     def validate(self, data):
         dref = data.get("dref")
+        if self.instance and self.instance.status == Dref.Status.FINALIZING:
+            raise serializers.ValidationError(gettext("Cannot be updated while the translation is in progress"))
         # Check if dref is published and operational_update associated with it is also published
         if not self.instance and dref:
             if dref.status != Dref.Status.APPROVED:
@@ -1247,18 +1249,13 @@ def create(self, validated_data):
         # else copy from dref
         dref = validated_data["dref"]
         current_language = get_language()
+        stating_langauge = validated_data.get("starting_language")
         valid_languages = [dref.starting_language, dref.translation_module_original_language]
-        # Check request language
-        if current_language not in valid_languages:
-            raise serializers.ValidationError(
-                gettext(f"Language must be either '{valid_languages[0]}' or '{valid_languages[1]}'.")
-            )
-
-        # Check payload language
-        language = validated_data.get("starting_language")
-        if language not in valid_languages:
+        if current_language != stating_langauge:
+            raise serializers.ValidationError(gettext("Starting language does not match the expected language."))
+        if stating_langauge not in valid_languages:
             raise serializers.ValidationError(
-                gettext(f"Language must be either '{valid_languages[0]}' or '{valid_languages[1]}'.")
+                gettext(f"Invalid starting language. Supported options are '{valid_languages[0]}' and '{valid_languages[1]}'.")
             )
         dref_operational_update = (
             DrefOperationalUpdate.objects.filter(dref=dref, status=Dref.Status.APPROVED)