Skip to content

Commit ca65199

Browse files
Merge pull request #2261 from IFRCGo/feature/tinymce-cleanup
TinyMCE cleanup - no selector is needed in settings
2 parents 10282b5 + 54feb91 commit ca65199

File tree

3 files changed

+1
-42
lines changed

3 files changed

+1
-42
lines changed

api/admin.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
from lang.admin import TranslationAdmin, TranslationInlineModelAdmin
2424
from notifications.models import RecordType, SubscriptionType
2525

26-
from .forms import ActionForm, DescriptionPlain, SocietyNameOverviewPlain, SummaryPlain
26+
from .forms import ActionForm
2727

2828
# from reversion.models import Revision
2929

@@ -183,12 +183,10 @@ class SituationReportInline(admin.TabularInline):
183183

184184
class EventFeaturedDocumentInline(admin.TabularInline):
185185
model = models.EventFeaturedDocument
186-
form = DescriptionPlain
187186

188187

189188
class EventLinkInline(admin.TabularInline, TranslationInlineModelAdmin):
190189
model = models.EventLink
191-
form = DescriptionPlain
192190

193191

194192
class EventAdmin(CompareVersionAdmin, RegionRestrictedAdmin, TranslationAdmin):
@@ -319,7 +317,6 @@ class FieldReportAdmin(CompareVersionAdmin, RegionRestrictedAdmin, TranslationAd
319317
"countries",
320318
"districts",
321319
)
322-
form = SummaryPlain
323320

324321
readonly_fields = ("report_date", "created_at", "updated_at")
325322
list_filter = [MembershipFilter]
@@ -652,7 +649,6 @@ class CountryAdmin(geoadmin.OSMGeoAdmin, CompareVersionAdmin, RegionRestrictedAd
652649
CountryICRCPresenceInline,
653650
]
654651
exclude = ("key_priorities",)
655-
form = SocietyNameOverviewPlain
656652

657653

658654
class RegionAdmin(geoadmin.OSMGeoAdmin, CompareVersionAdmin, RegionRestrictedAdmin, TranslationAdmin):

api/forms.py

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -11,38 +11,3 @@ class ActionForm(forms.ModelForm):
1111
class Meta:
1212
model = Action
1313
fields = "__all__"
14-
15-
16-
class SocietyNameOverviewPlain(forms.ModelForm):
17-
class Meta:
18-
widgets = {
19-
"society_name_en": forms.Textarea(attrs={"class": "plain-textarea"}),
20-
"society_name_es": forms.Textarea(attrs={"class": "plain-textarea"}),
21-
"society_name_fr": forms.Textarea(attrs={"class": "plain-textarea"}),
22-
"society_name_ar": forms.Textarea(attrs={"class": "plain-textarea"}),
23-
"overview_en": forms.Textarea(attrs={"class": "plain-textarea"}),
24-
"overview_es": forms.Textarea(attrs={"class": "plain-textarea"}),
25-
"overview_fr": forms.Textarea(attrs={"class": "plain-textarea"}),
26-
"overview_ar": forms.Textarea(attrs={"class": "plain-textarea"}),
27-
}
28-
29-
30-
class SummaryPlain(forms.ModelForm):
31-
class Meta:
32-
widgets = {
33-
"summary_en": forms.Textarea(attrs={"class": "plain-textarea"}),
34-
"summary_es": forms.Textarea(attrs={"class": "plain-textarea"}),
35-
"summary_fr": forms.Textarea(attrs={"class": "plain-textarea"}),
36-
"summary_ar": forms.Textarea(attrs={"class": "plain-textarea"}),
37-
}
38-
39-
40-
class DescriptionPlain(forms.ModelForm):
41-
class Meta:
42-
widgets = {
43-
"description": forms.Textarea(attrs={"class": "plain-textarea"}),
44-
"description_en": forms.Textarea(attrs={"class": "plain-textarea"}),
45-
"description_es": forms.Textarea(attrs={"class": "plain-textarea"}),
46-
"description_fr": forms.Textarea(attrs={"class": "plain-textarea"}),
47-
"description_ar": forms.Textarea(attrs={"class": "plain-textarea"}),
48-
}

main/settings.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,9 +331,7 @@
331331
},
332332
]
333333

334-
# selector – exclude Geometry fields (bbox) and some plain textareas (see forms.py)
335334
TINYMCE_DEFAULT_CONFIG = {
336-
"selector": "textarea.vLargeTextField",
337335
"entity_encoding": "raw",
338336
"height": 360,
339337
"width": 1120,

0 commit comments

Comments
 (0)