Merge pull request #2002 from IFRCGo/feature/enable-no-unchecked-indexed-access

Enable noUncheckedIndexedAccess rule

Author: frozenhelium

app/src/App/index.tsx

@@ -105,7 +105,7 @@ function Application() {
             }
 
             const updatedAlert = {
-                ...prevAlerts[i],
+                ...prevAlerts[i]!,
                 paramsWithoutName,
             };
 

app/src/components/domain/AppealsOverYearsChart/MonthlyChart/index.tsx

@@ -44,7 +44,7 @@ const dataKeyToClassNameMap = {
     dref: styles.dref,
     emergencyAppeal: styles.emergencyAppeal,
 };
-const classNameSelector = (dataKey: DATA_KEY) => dataKeyToClassNameMap[dataKey];
+const classNameSelector = (dataKey: DATA_KEY) => dataKeyToClassNameMap[dataKey]!;
 const xAxisFormatter = (date: Date) => date.toLocaleString(
     navigator.language,
     { month: 'short' },
@@ -81,7 +81,8 @@ function MonthlyChart(props: Props) {
     );
 
     const [activePointKey, setActivePointKey] = useState<string>(
-        () => getFormattedDateKey(dateList[0]),
+        // FIXME: add proper not null check
+        () => getFormattedDateKey(dateList[0]!),
     );
 
     const query = {

app/src/components/domain/AppealsOverYearsChart/YearlyChart/index.tsx

@@ -49,7 +49,7 @@ const dataKeyToClassNameMap = {
     dref: styles.dref,
     emergencyAppeal: styles.emergencyAppeal,
 };
-const classNameSelector = (dataKey: DATA_KEY) => dataKeyToClassNameMap[dataKey];
+const classNameSelector = (dataKey: DATA_KEY) => dataKeyToClassNameMap[dataKey]!;
 const xAxisFormatter = (date: Date) => date.toLocaleString(
     navigator.language,
     { year: 'numeric' },
@@ -68,7 +68,7 @@ function YearlyChart(props: Props) {
     const strings = useTranslation(i18n);
 
     const [activePointKey, setActivePointKey] = useState<string>(
-        () => getFormattedDateKey(dateList[dateList.length - 1]),
+        () => getFormattedDateKey(dateList[dateList.length - 1]!),
     );
 
     const queryParams = {

app/src/components/domain/GoMultiFileInput/index.tsx

@@ -37,7 +37,11 @@ interface FileUploadResult {
 const keySelector = (d: FileUploadResult) => d.id;
 const valueSelector = (d: FileUploadResult) => d.file;
 
-function getFileNameFromUrl(urlString: string) {
+function getFileNameFromUrl(urlString: string | undefined) {
+    if (isNotDefined(urlString)) {
+        return undefined;
+    }
+
     const url = new URL(urlString);
     const splits = url.pathname.split('/');
     return splits[splits.length - 1];

app/src/components/domain/HighlightedOperations/OperationCard/index.tsx

@@ -111,7 +111,7 @@ function OperationCard(props: Props) {
 
     let countriesInfoDisplay = strings.operationCardNoCountryInvolved;
     if (countries.length === 1) {
-        countriesInfoDisplay = countries[0].name ?? '?';
+        countriesInfoDisplay = countries[0]!.name ?? '?';
     } else if (countries.length > 1) {
         countriesInfoDisplay = strings.operationCardInvolvesMultipleCountries;
     }

app/src/components/domain/HistoricalDataChart/index.tsx

@@ -74,7 +74,7 @@ function isValidDisaster(
     if (isFalsyString(disaster.name)) {
         return false;
     }
-    return validDisastersForChart[disaster.id];
+    return validDisastersForChart[disaster.id]!;
 }
 
 const hazardIdToColorMap: Record<number, string> = {

app/src/components/domain/RiskImminentEvents/MeteoSwiss/EventDetails/index.tsx

@@ -126,7 +126,7 @@ function EventDetails(props: Props) {
 
                 if (impact_type.startsWith('exposed_population_')) {
                     const windspeed = Number.parseInt(
-                        impact_type.split('exposed_population_')[1],
+                        impact_type.split('exposed_population_')[1]!,
                         10,
                     );
 

app/src/components/domain/RiskSeasonalMap/index.tsx

@@ -94,7 +94,7 @@ interface TooltipContentProps {
         value: number;
         riskCategory: number;
         hazard_type: HazardType;
-        hazard_type_display: string;
+        hazard_type_display: string | undefined;
     }[];
 }
 
@@ -603,12 +603,12 @@ function RiskSeasonalMap(props: Props) {
 
             type RiskDataItemWithHazard = RiskDataItem & {
                 hazard_type: HazardType;
-                hazard_type_display: string;
+                hazard_type_display: string | undefined;
                 country_details: {
                     id: number;
                     name?: string | null;
                     iso3?: string | null;
-                }
+                } | undefined;
             }
 
             function groupByCountry(riskDataList: RiskDataItemWithHazard[] | undefined) {
@@ -647,7 +647,7 @@ function RiskSeasonalMap(props: Props) {
                 const transformedList = mapToList(
                     groupByCountry(riskDataList),
                     (itemList, key) => {
-                        const firstItem = itemList[0];
+                        const firstItem = itemList[0]!;
                         const valueListByHazard = itemList.map(
                             (item) => {
                                 const value = getValueForSelectedMonths(
@@ -767,21 +767,25 @@ function RiskSeasonalMap(props: Props) {
                 ).sort((a, b) => compareNumber(a.riskCategorySum, b.riskCategorySum, -1));
             }
 
+            if (isNotDefined(data)) {
+                return undefined;
+            }
+
             if (filters.riskMetric === 'displacement') {
                 return transformRiskData(
-                    data?.displacement,
+                    data.displacement,
                 );
             }
 
             if (filters.riskMetric === 'exposure') {
                 return transformRiskData(
-                    data?.exposure,
+                    data.exposure,
                 );
             }
 
             if (filters.riskMetric === 'riskScore') {
                 const transformedData = transformRiskData(
-                    data?.riskScore,
+                    data.riskScore,
                     'max',
                 );
 

app/src/components/domain/SeverityIndicator/index.tsx

@@ -17,7 +17,8 @@ function SeverityIndicator(props: Props) {
         title,
         className,
     } = props;
-    const classNameMap: Record<number, string> = {
+
+    const classNameMap: Record<number, string | undefined> = {
         0: styles.yellow,
         1: styles.orange,
         2: styles.red,

app/src/hooks/useNumericChartData.ts

@@ -169,7 +169,7 @@ function useNumericChartData<DATUM>(data: DATUM[] | null | undefined, options: O
 
             const tickWithLowestOffset = [...potentialTicks].sort(
                 (a, b) => compareNumber(a.rank, b.rank, -1),
-            )[0];
+            )[0]!;
 
             return bound(
                 tickWithLowestOffset.numTicks,