Skip to content

Commit 13277e3

Browse files
authored
Merge pull request #353 from IFRCGo/fix/export-margin
Fix export margin
2 parents faf5904 + 5c2c17d commit 13277e3

File tree

5 files changed

+9
-6
lines changed

5 files changed

+9
-6
lines changed

src/components/domain/AppealsTable/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ function AppealsTable(props: Props) {
125125
createStringColumn<AppealListItem, string>(
126126
'dtype',
127127
strings.appealsTableDisastertype,
128-
(item) => item.dtype.name,
128+
(item) => item.dtype?.name,
129129
{ sortable: true },
130130
),
131131
createNumberColumn<AppealListItem, string>(
@@ -152,7 +152,7 @@ function AppealsTable(props: Props) {
152152
createLinkColumn<AppealListItem, string>(
153153
'country',
154154
strings.appealsTableCountry,
155-
(item) => item.country.name,
155+
(item) => item.country?.name,
156156
(item) => ({
157157
to: 'countriesLayout',
158158
urlParams: { countryId: item.country.id },

src/components/domain/RiskImminentEventMap/i18n.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"namespace": "common",
33
"strings": {
44
"riskImminentEventsMap": "Risk Imminent Events Map",
5-
"backToEventsLabel": "Back to events"
5+
"backToEventsLabel": "Back to events",
6+
"emptyImminentEventMessage": "No imminent event forecasted"
67
}
78
}

src/components/domain/RiskImminentEventMap/index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -339,6 +339,7 @@ function RiskImminentEventMap<
339339
keySelector={keySelector}
340340
renderer={listItemRenderer}
341341
rendererParams={eventListRendererParams}
342+
emptyMessage={strings.emptyImminentEventMessage}
342343
/>
343344
)}
344345
{isDefined(activeEvent) && (

src/index.css

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
--base-font-size: 0.875rem;
77
--go-ui-font-size-export: 0.6875rem;
8-
--go-ui-export-page-margin: 10mm 10mm 16mm 10mm;
98

109
--go-ui-font-size-2xs: calc(var(--base-font-size) * 0.625);
1110
--go-ui-font-size-xs: calc(var(--base-font-size) * 0.75);
@@ -227,6 +226,8 @@
227226
--go-ui-page-header-description-width-max: var(--go-ui-width-content-max);
228227
--go-ui-page-width-max: 90rem;
229228
--mapbox-icon-width: 88px;
229+
230+
--go-ui-export-page-margin: 10mm 10mm 16mm 10mm;
230231
}
231232

232233
* {
@@ -262,7 +263,7 @@ ul, ol, p {
262263
@media print {
263264
@page {
264265
size: portrait A4;
265-
margin: var(--go-ui-export-page-margin);
266+
margin: 10mm 10mm 16mm 10mm;
266267
}
267268

268269
body {

src/utils/domain/risk.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ export function getAverageIpcData(uniqueData: IpcData) {
228228
);
229229

230230
const monthlyValueList = Object.values(ipcRiskDataItem ?? {});
231-
const annual_average = avgSafe(monthlyValueList);
231+
const annual_average = sumSafe(monthlyValueList);
232232

233233
return {
234234
...ipcRiskDataItem,

0 commit comments

Comments
 (0)