Skip to content

Commit 5d43975

Browse files
committed
Improve styling of breadcrumbs
1 parent bb4b6f0 commit 5d43975

File tree

10 files changed

+24
-10
lines changed

10 files changed

+24
-10
lines changed

src/components/Breadcrumbs/index.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,10 @@ function Breadcrumbs(props: BreadcrumbsProps) {
4949
);
5050

5151
return (
52-
<nav className={_cs(className, styles.breadcrumbs)} aria-label="breadcrumb">
52+
<nav
53+
className={_cs(styles.breadcrumbs, className)}
54+
aria-label="breadcrumb"
55+
>
5356
{items}
5457
</nav>
5558
);

src/components/Breadcrumbs/styles.module.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
.breadcrumbs {
22
display: flex;
33
align-items: center;
4+
flex-wrap: wrap;
45

56
.item {
67
display: flex;

src/components/Container/index.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ export interface Props {
4545
headingLevel?: HeadingProps['level'],
4646
headingSectionClassName?: string;
4747
icons?: React.ReactNode;
48+
iconsContainerClassName?: string;
4849
numPreferredGridContentColumns?: NumColumn;
4950
spacing?: SpacingType;
5051
withGridViewInFilter?: boolean;
@@ -83,6 +84,7 @@ function Container(props: Props) {
8384
headingLevel,
8485
headingSectionClassName,
8586
icons,
87+
iconsContainerClassName,
8688
numPreferredGridContentColumns = 2,
8789
spacing = 'default',
8890
withGridViewInFilter = false,
@@ -143,6 +145,7 @@ function Container(props: Props) {
143145
heading={heading}
144146
headingLevel={headingLevel}
145147
icons={icons}
148+
iconsContainerClassName={iconsContainerClassName}
146149
childrenContainerClassName={headerDescriptionContainerClassName}
147150
headingSectionClassName={headingSectionClassName}
148151
headingClassName={headingClassName}

src/components/DropdownMenu/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,8 @@ function DropdownMenu(props: Props) {
121121
<>
122122
{actions}
123123
{!withoutDropdownIcon && (showDropdown
124-
? <ArrowUpSmallFillIcon />
125-
: <ArrowDownSmallFillIcon />
124+
? <ArrowUpSmallFillIcon className={styles.dropdownIcon} />
125+
: <ArrowDownSmallFillIcon className={styles.dropdownIcon} />
126126
)}
127127
</>
128128
) : undefined}

src/components/DropdownMenu/styles.module.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@
44
.actions {
55
pointer-events: none;
66
}
7+
8+
.dropdown-icon {
9+
margin-inline-start: -0.3em;
10+
font-size: var(--go-ui-height-icon-multiplier);
11+
}
712
}
813

914
.dropdown-content {

src/components/GlobalFooter/styles.module.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
.section {
1111
display: flex;
12-
flex-basis: 10rem;
12+
flex-basis: 12rem;
1313
flex-direction: column;
1414
flex-grow: 1;
1515
gap: var(--go-ui-spacing-lg);

src/components/Link/styles.module.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,6 @@
5151

5252
.forward-icon {
5353
font-size: var(--go-ui-height-icon-multiplier);
54+
margin-inline-start: -0.3em;
5455
}
5556
}

src/components/PageHeader/index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ function PageHeader(props: Props) {
4949
<Container
5050
className={styles.container}
5151
icons={breadCrumbs}
52+
iconsContainerClassName={styles.breadcrumbsContainer}
5253
actions={(actions || wikiLink) && (
5354
<>
5455
{actions}

src/components/PageHeader/styles.module.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
flex-direction: column;
77
gap: var(--go-ui-spacing-xl);
88

9+
.breadcrumbs-container {
10+
flex-shrink: unset;
11+
}
12+
913
.header {
1014
display: flex;
1115
align-items: center;

src/views/Emergency/index.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -203,14 +203,10 @@ export function Component() {
203203
title={strings.emergencyPageTitle}
204204
breadCrumbs={(
205205
<Breadcrumbs>
206-
<Link
207-
to="home"
208-
>
206+
<Link to="home">
209207
{strings.home}
210208
</Link>
211-
<Link
212-
to="emergencies"
213-
>
209+
<Link to="emergencies">
214210
{strings.emergencies}
215211
</Link>
216212
<Link

0 commit comments

Comments
 (0)