chore(typings): fix risk server related typings

Author: frozenhelium

app/src/components/domain/ActivityEventSearchSelectInput.tsx

@@ -13,7 +13,7 @@ import {
 
 type GetEventParams = GoApiUrlQuery<'/api/v2/event/response-activity/'>;
 type GetEventResponse = GoApiResponse<'/api/v2/event/response-activity/'>;
-export type EventItem = Pick<NonNullable<GetEventResponse['results']>[number], 'id' | 'name' | 'dtype' | 'emergency_response_contact_email'>;
+export type EventItem = Pick<NonNullable<GetEventResponse['results']>[number], 'id' | 'name' | 'dtype'>;
 
 const keySelector = (d: EventItem) => d.id;
 const labelSelector = (d: EventItem) => d.name ?? '???';

app/src/components/domain/RiskImminentEvents/Gdacs/index.tsx

@@ -3,6 +3,7 @@ import { numericIdSelector } from '@ifrc-go/ui/utils';
 import {
     isDefined,
     isNotDefined,
+    isObject,
 } from '@togglecorp/fujs';
 import { type LngLatBoundsLike } from 'mapbox-gl';
 
@@ -229,7 +230,13 @@ function Gdacs(props: Props) {
                 ? footprint_geojson
                 : undefined;
 
-            const hazardDate = (footprint?.metadata as ({ todate?: string } | undefined))?.todate;
+            const hazardDate = (isDefined(footprint)
+                && 'metadata' in footprint
+                && isObject(footprint.metadata)
+                && 'todate' in footprint.metadata
+            )
+                ? String(footprint.metadata.todate)
+                : undefined;
 
             const geoJson: GeoJSON.FeatureCollection<GeoJSON.Geometry, RiskLayerProperties> = {
                 type: 'FeatureCollection' as const,

app/src/components/domain/RiskImminentEvents/MeteoSwiss/index.tsx

@@ -3,6 +3,7 @@ import { numericIdSelector } from '@ifrc-go/ui/utils';
 import {
     isDefined,
     isNotDefined,
+    isObject,
 } from '@togglecorp/fujs';
 import type { LngLatBoundsLike } from 'mapbox-gl';
 
@@ -155,7 +156,11 @@ function MeteoSwiss(props: Props) {
             }
 
             // FIXME: fix typing in server (low priority)
-            const footprint_geojson = exposure?.footprint_geojson?.footprint_geojson;
+            const footprint_geojson = 'footprint_geojson' in exposure
+                && isObject(exposure.footprint_geojson)
+                && 'footprint_geojson' in exposure.footprint_geojson
+                ? exposure.footprint_geojson?.footprint_geojson
+                : undefined;
 
             if (isNotDefined(footprint_geojson)) {
                 return undefined;

app/src/components/domain/RiskImminentEvents/Pdc/index.tsx

@@ -138,7 +138,8 @@ function Pdc(props: Props) {
             } = exposure;
 
             // FIXME: showing five days cou when three days cou is not available
-            const cyclone_cou = cyclone_three_days_cou?.[0] ?? cyclone_five_days_cou?.[0];
+            const cyclone_cou = (cyclone_three_days_cou as unknown[] | null)?.[0]
+                ?? (cyclone_five_days_cou as unknown[])?.[0];
 
             if (isNotDefined(footprint_geojson) && isNotDefined(storm_position_geojson)) {
                 return undefined;

app/src/views/AllDeployedPersonnel/index.tsx

@@ -25,6 +25,7 @@ import {
 import { saveAs } from 'file-saver';
 import Papa from 'papaparse';
 
+import { type EventItem } from '#components/domain/ActivityEventSearchSelectInput';
 import CountrySelectInput from '#components/domain/CountrySelectInput';
 import EventSearchSelectInput from '#components/domain/EventSearchSelectInput';
 import ExportButton from '#components/domain/ExportButton';
@@ -135,7 +136,7 @@ export function Component() {
         (country) => country,
     );
 
-    const [positionFilter, setPositionFilter] = useUrlSearchState<string>(
+    const [positionFilter, setPositionFilter] = useUrlSearchState<string | undefined>(
         'role',
         (searchValue) => searchValue ?? '',
         (value) => value,
@@ -176,7 +177,7 @@ export function Component() {
                     summary: undefined,
                 },
                 name,
-            };
+            } satisfies EventItem;
 
             setEventOptions((prevOptions) => ([
                 ...prevOptions ?? [],
@@ -395,26 +396,22 @@ export function Component() {
                             name="role"
                             value={positionFilter}
                             onChange={setPositionFilter}
-                            placeholder={strings.defaultPlaceholder}
                         />
                         <NationalSocietySelectInput
                             label={strings.personnelTableDeployingParty}
                             name="deploying_party"
-                            placeholder={strings.defaultPlaceholder}
                             value={nationalSocietyFilter}
                             onChange={setNationalSocietyFilter}
                         />
                         <CountrySelectInput
                             label={strings.personnelTableDeployedTo}
                             name="deployed_to"
-                            placeholder={strings.defaultPlaceholder}
                             value={countryToFilter}
                             onChange={setCountryToFilter}
                         />
                         <EventSearchSelectInput
                             name="event"
                             label={strings.personnelTableEmergency}
-                            placeholder={strings.defaultPlaceholder}
                             value={eventFilter}
                             onChange={setEventFilter}
                             options={eventOptions}

app/src/views/ThreeWActivityForm/index.tsx

@@ -173,6 +173,14 @@ export function Component() {
         DistrictItem[] | undefined | null
     >([]);
 
+    const { response: selectedEventDetail } = useRequest({
+        skip: isNotDefined(value.event),
+        url: '/api/v2/event/{id}/',
+        pathVariables: isDefined(value.event) ? {
+            id: value.event,
+        } : undefined,
+    });
+
     const {
         pending: fetchingActivity,
         response: activityResponse,
@@ -543,13 +551,6 @@ export function Component() {
         createActivity,
     ]);
 
-    const selectedEventDetail = useMemo(() => (
-        eventOptions?.find((event) => event.id === value?.event)
-    ), [
-        eventOptions,
-        value?.event,
-    ]);
-
     const countries = useCountry();
     const nationalSocieties = useNationalSociety();