Remove unused variables, functions, dependencies and exports

- Fix undefined string for Navbar
- Move knip configuration to main workspace
- Completely remove APP_SHOW_ENV_BANNER
- Use working-directory on all github workflow

Author: tnagorra

.github/workflows/ci.yml

@@ -48,7 +48,7 @@ jobs:
       - name: Lint JS
         run: yarn lint:js
 
-      - name: build  UI library
+      - name: Build
         run: yarn build
 
       - uses: actions/upload-artifact@v4
@@ -60,6 +60,9 @@ jobs:
     name: Run tests
     environment: 'test'
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: app
     needs: [ui]
     steps:
       - uses: actions/checkout@v4
@@ -75,15 +78,16 @@ jobs:
 
       - name: Install dependencies
         run: yarn install --frozen-lockfile
-        working-directory: app
 
       - name: Run test
         run: yarn test
-        working-directory: app
 
   translation:
     name: Identify error with translation files
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: app
     needs: [ui]
     steps:
       - uses: actions/checkout@v4
@@ -99,11 +103,9 @@ jobs:
 
       - name: Install dependencies
         run: yarn install --frozen-lockfile
-        working-directory: app
 
       - name: Identify error with translation files
         run: yarn lint:translation
-        working-directory: app
 
   unimported:
     name: Identify unused files
@@ -116,22 +118,22 @@ jobs:
           node-version: 20
           cache: 'yarn'
 
-      - uses: actions/download-artifact@v4
-        with:
-          name: ui-build
-          path: packages/ui/dist
+      - name: Install dependencies
+        run: yarn initialize:type
+        working-directory: app
 
       - name: Install dependencies
         run: yarn install --frozen-lockfile
-        working-directory: app
 
       - name: Identify unused files
         run: yarn lint:unused
-        working-directory: app
 
   lint:
     name: Lint JS
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: app
     needs: [ui]
     steps:
       - uses: actions/checkout@v4
@@ -147,15 +149,16 @@ jobs:
 
       - name: Install dependencies
         run: yarn install --frozen-lockfile
-        working-directory: app
 
       - name: Lint JS
         run: yarn lint:js
-        working-directory: app
 
   lint-css:
     name: Lint CSS
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: app
     needs: [ui]
     steps:
       - uses: actions/checkout@v4
@@ -171,11 +174,9 @@ jobs:
 
       - name: Install dependencies
         run: yarn install --frozen-lockfile
-        working-directory: app
 
       - name: Lint CSS
         run: yarn lint:css
-        working-directory: app
 
   # FIXME: Identify a way to generate schema before we run typecheck
   # typecheck:
@@ -196,8 +197,11 @@ jobs:
   build:
     name: Build GO Web App
     environment: 'test'
-    needs: [lint, lint-css, test, ui]
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: app
+    needs: [lint, lint-css, test, ui]
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
@@ -212,11 +216,9 @@ jobs:
 
       - name: Install dependencies
         run: yarn install --frozen-lockfile
-        working-directory: app
 
       - name: Build
         run: yarn build
-        working-directory: app
 
   validate_helm:
     name: Validate Helm

app/env.ts

@@ -17,7 +17,6 @@ export default defineConfig({
     },
     APP_API_ENDPOINT: Schema.string({ format: 'url', protocol: true, tld: false }),
     APP_ADMIN_URL: Schema.string.optional({ format: 'url', protocol: true }),
-    APP_SHOW_ENV_BANNER: Schema.boolean.optional(),
     APP_MAPBOX_ACCESS_TOKEN: Schema.string(),
     APP_TINY_API_KEY: Schema.string(),
     APP_RISK_API_ENDPOINT: Schema.string({ format: 'url', protocol: true }),

app/knip.json

@@ -19,7 +19,6 @@
         "prestart": "yarn initialize:type",
         "pretypecheck": "yarn initialize:type",
         "prelint:js": "yarn initialize:type",
-        "prelint:unused": "yarn initialize:type",
         "prebuild": "yarn initialize:type",
         "start": "vite",
         "build": "vite build",
@@ -30,10 +29,8 @@
         "typecheck": "tsc",
         "lint:js": "eslint src",
         "lint:css": "stylelint \"./src/**/*.css\"",
-        "lint:unused": "unimported",
-        "lint:unused-new": "knip --tags=-knipignore",
         "lint:translation": "yarn translatte:lint",
-        "lint": "yarn lint:js && yarn lint:css && yarn lint:unused && yarn lint:translation",
+        "lint": "yarn lint:js && yarn lint:css && yarn lint:translation",
         "lint:fix": "yarn lint:js --fix && yarn lint:css --fix",
         "test": "vitest",
         "test:coverage": "vitest run --coverage",
@@ -65,10 +62,10 @@
     },
     "devDependencies": {
         "@eslint/eslintrc": "^3.1.0",
+        "@eslint/js": "^9.14.0",
         "@eslint/json": "^0.5.0",
         "@julr/vite-plugin-validate-env": "^1.0.1",
         "@types/file-saver": "^2.0.5",
-        "@types/html2canvas": "^1.0.0",
         "@types/mapbox-gl": "^1.13.0",
         "@types/node": "^20.11.6",
         "@types/papaparse": "^5.3.8",
@@ -94,9 +91,8 @@
         "eslint-plugin-react-hooks": "^5.0.0",
         "eslint-plugin-react-refresh": "^0.4.13",
         "eslint-plugin-simple-import-sort": "^12.1.1",
-        "fast-glob": "^3.3.0",
+        "fast-glob": "^3.3.2",
         "happy-dom": "^9.18.3",
-        "knip": "^5.36.3",
         "openapi-typescript": "6.5.5",
         "patch-package": "^7.0.0",
         "postcss": "^8.3.0",
@@ -114,7 +110,6 @@
         "ts-md5": "^1.3.1",
         "tsx": "^4.7.2",
         "typescript": "^5.5.2",
-        "unimported": "1.28.0",
         "vite": "^5.0.10",
         "vite-plugin-checker": "^0.6.2",
         "vite-plugin-compression2": "^0.11.0",

app/package.json

@@ -1,17 +1,17 @@
-export interface MigrationAddActionItem {
+interface MigrationAddActionItem {
     action: 'add',
     key: string,
     value: string,
     namespace: string,
 }
 
-export interface MigrationRemoveActionItem {
+interface MigrationRemoveActionItem {
     action: 'remove',
     key: string,
     namespace: string,
 }
 
-export interface MigrationUpdateActionItem {
+interface MigrationUpdateActionItem {
     action: 'update',
     key: string,
     namespace: string,

app/scripts/translatte/types.ts

@@ -1,7 +1,7 @@
 import { join, isAbsolute, basename } from 'path';
-import fg from 'fast-glob';
 import { promisify } from 'util';
 import { readFile, writeFile, unlink } from 'fs';
+import glob from 'fast-glob';
 import {
     isDefined,
     intersection,
@@ -17,10 +17,9 @@ import {
     SourceFileContent,
 } from './types';
 
-export const readFilePromisify = promisify(readFile);
+const readFilePromisify = promisify(readFile);
 export const writeFilePromisify = promisify(writeFile);
-export const unlinkPromisify = promisify(unlink);
-export const glob = fg.glob;
+const unlinkPromisify = promisify(unlink);
 
 // Utilities
 

app/scripts/translatte/utils.ts

@@ -31,7 +31,7 @@ export type ExtendedProps = {
     ) => boolean;
 };
 
-export interface CustomWrapRoute {
+interface CustomWrapRoute {
     <T>(
         myRouteOptions: MyInputIndexRouteObject<T, ExtendedProps>
     ): MyOutputIndexRouteObject<ExtendedProps>

app/src/App/routes/common.tsx

@@ -113,7 +113,7 @@ Omit<{
     spacing?: ButtonFeatureProps['spacing'];
 }, OMISSION>
 
-export type InternalLinkProps = {
+type InternalLinkProps = {
     external?: never;
     to: keyof WrappedRoutes | undefined | null;
     urlParams?: UrlParams;

app/src/components/Link/index.tsx

@@ -59,6 +59,7 @@
         "userMenuTools":"Tools",
         "userMenuResources":"Resources",
         "userMenuGoBlog":"GO Blog",
+        "userMenuOperationalLearning":"Operational Learning",
         "userMenuOperationalLearningDescription":"Operational learning in emergencies is the lesson learned from managing and dealing with crises, refining protocols for resource allocation, decision-making, communication strategies, and others.",
         "userMenuOperationalToolboxItem":"Operational Toolbox",
         "userMenuOperationalToolboxItemDescription":"This operational toolbox is a central repository with key operational document helpful for your mission like templates, checklists, guidance and examples.",

app/src/components/Navbar/i18n.json

@@ -16,7 +16,7 @@ import {
 import i18n from './i18n.json';
 import styles from './styles.module.css';
 
-export interface Props<T> {
+interface Props<T> {
     className?: string;
     error?: Error<T>;
     withFallbackError?: boolean;