Skip to content

Commit e59b8d5

Browse files
committed
VAL-505 Updated the usage of the getDependencies method in Module Storage Coordinator service
1 parent 5ad8831 commit e59b8d5

File tree

1 file changed

+21
-7
lines changed

1 file changed

+21
-7
lines changed

src/main/java/org/ihtsdo/rvf/core/service/ValidationVersionLoader.java

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,11 @@ public void downloadDependencyReleases(ValidationRunConfig validationConfig) thr
441441
logger.info("No MDRS found from prospective file");
442442
return;
443443
}
444-
Set<ModuleMetadata> dependencies = moduleStorageCoordinator.getDependencies(mdrsRows, true);
444+
Set<String> expectedModules = new HashSet<>();
445+
if (validationConfig.getIncludedModules() != null) {
446+
expectedModules.addAll(Arrays.stream(validationConfig.getIncludedModules().split(",")).map(String::trim).toList());
447+
}
448+
Set<ModuleMetadata> dependencies = moduleStorageCoordinator.getDependencies(mdrsRows, expectedModules, true);
445449
if (!dependencies.isEmpty()) {
446450
String localDirectory = createRunningDirectory(validationConfig.getRunId().toString());
447451
for (ModuleMetadata dependency : dependencies) {
@@ -465,7 +469,6 @@ public void downloadDependencyReleases(ValidationRunConfig validationConfig) thr
465469
} else {
466470
logger.info("No dependency found from Module Storage Coordinator");
467471
}
468-
469472
}
470473

471474
public void downloadPreviousRelease(ValidationRunConfig validationConfig) throws ModuleStorageCoordinatorException.OperationFailedException, ModuleStorageCoordinatorException.ResourceNotFoundException, ModuleStorageCoordinatorException.InvalidArgumentsException, IOException, BusinessServiceException {
@@ -506,7 +509,9 @@ private void downloadPreviousReleaseFromModuleStorageCoordinator(ValidationRunCo
506509
Files.copy(releaseFile.toPath(), localPreviousRelease.toPath(), StandardCopyOption.REPLACE_EXISTING);
507510
validationConfig.addLocalReleaseFile(localPreviousRelease);
508511
validationConfig.addReleaseCreationTime(moduleMetadata.getFilename(), moduleMetadataList.get(0).getFileTimeStamp().getTime());
509-
processDependenciesFromFile(localPreviousRelease, validationConfig);
512+
if (validationConfig.isReleaseAsAnEdition()) {
513+
processDependenciesFromFile(localPreviousRelease, validationConfig);
514+
}
510515
} finally {
511516
Files.delete(releaseFile.toPath());
512517
}
@@ -530,7 +535,9 @@ private void downloadPreviousReleaseFromFallbackSource(ValidationRunConfig valid
530535
}
531536
validationConfig.addLocalReleaseFile(localPreviousRelease);
532537
validationConfig.addReleaseCreationTime(validationConfig.getPreviousRelease(), releaseSourceManager.getResourceLastModifiedDate(validationConfig.getPreviousRelease()));
533-
processDependenciesFromFile(localPreviousRelease, validationConfig);
538+
if (validationConfig.isReleaseAsAnEdition()) {
539+
processDependenciesFromFile(localPreviousRelease, validationConfig);
540+
}
534541
}
535542

536543
private File prepareLocalFile(String localDirectory, String filename) throws IOException {
@@ -547,11 +554,18 @@ private File prepareLocalFile(String localDirectory, String filename) throws IOE
547554
private void processDependenciesFromFile(File releaseFile, ValidationRunConfig validationConfig) {
548555
RF2Service rf2Service = new RF2Service();
549556
Set<RF2Row> mdrsRows = rf2Service.getMDRS(releaseFile, false);
550-
Set<ModuleMetadata> dependencies = moduleStorageCoordinator.getDependencies(mdrsRows, false);
557+
Set<String> expectedModules = new HashSet<>();
558+
if (validationConfig.getIncludedModules() != null) {
559+
expectedModules.addAll(Arrays.stream(validationConfig.getIncludedModules().split(",")).map(String::trim).toList());
560+
}
561+
Set<ModuleMetadata> dependencies = moduleStorageCoordinator.getDependencies(mdrsRows, expectedModules, false);
551562
if (!CollectionUtils.isEmpty(dependencies)) {
552-
dependencies.forEach(dependency -> validationConfig.addPreviousDependencyEffectiveTime(
563+
dependencies.forEach(dependency -> {
564+
logger.info("Found previous dependency effective time: IdentifyingModuleId {}, EffectiveTime {}", dependency.getIdentifyingModuleId(), dependency.getEffectiveTimeString());
565+
validationConfig.addPreviousDependencyEffectiveTime(
553566
dependency.getIdentifyingModuleId(),
554-
dependency.getEffectiveTimeString()));
567+
dependency.getEffectiveTimeString());
568+
});
555569
}
556570
}
557571

0 commit comments

Comments
 (0)