Temporary volumes are set to be unique to configuration files (and the run_id)

Author: frankcorneliusmartin

vantage/node/__init__.py

@@ -346,10 +346,10 @@ def __start_task(self, taskresult):
         else:
             database_uri = self.config['databases']["default"]
 
-        # create a temporary volume for each run_id (tmp_{run_id})
-        self.__docker.create_temporary_volume(task["run_id"])
-        # self.__docker.client.containers.get(self.ctx.docker_container_name)
-
+        # create a temporary volume for each run_id       
+        vol_name = self.ctx.docker_temporary_volume_name(task["run_id"])
+        self.__docker.create_volume(vol_name)
+        
         # start docker container in the background
         if type(taskresult['input']) == dict:
             taskresult['input'] = json.dumps(taskresult['input'])
@@ -358,7 +358,7 @@ def __start_task(self, taskresult):
             image=task["image"],
             database_uri=database_uri,
             docker_input=taskresult['input'],
-            run_id=task["run_id"],
+            tmp_vol_name=vol_name,
             token=token
         )
 

vantage/node/docker_manager.py

@@ -91,7 +91,7 @@ def create_isolated_network(self, name: str) \
 
         return network
 
-    def create_temporary_volume(self, run_id: int):
+    def create_volume(self, volume_name: str):
         """ Create a temporary volume for a single run.
 
             A single run can consist of multiple algorithm containers. 
@@ -100,7 +100,6 @@ def create_temporary_volume(self, run_id: int):
 
             :param run_id: integer representing the run_id
         """
-        volume_name = f"tmp_{run_id}"
         try:
             self.client.volumes.get(volume_name)
             self.log.debug(f"Volume {volume_name} already exists.")
@@ -109,7 +108,7 @@ def create_temporary_volume(self, run_id: int):
             self.client.volumes.create(volume_name)
 
     def run(self, result_id: int,  image: str, database_uri: str, 
-                docker_input: str, run_id: int, token: str) -> bool:
+        docker_input: str, tmp_vol_name: int, token: str) -> bool:
         """ Runs the docker-image in detached mode.
 
             It will will attach all mounts (input, output and datafile)
@@ -158,7 +157,7 @@ def run(self, result_id: int,  image: str, database_uri: str,
         # define enviroment variables for the docker-container, the 
         # host, port and api_path are from the local proxy server to 
         # facilitate indirect communication with the central server
-        tmp_folder = "/mnt/tmp"
+        tmp_folder = "/mnt/tmp" # docker env
         environment_variables = {
             "INPUT_FILE": str(io_path / "input.txt"),
             "OUTPUT_FILE": str(io_path / "output.txt"),
@@ -180,7 +179,7 @@ def run(self, result_id: int,  image: str, database_uri: str,
                 environment=environment_variables,
                 network=self.isolated_network.name,
                 volumes={
-                    f"tmp_{run_id}":{
+                    tmp_vol_name:{
                         "bind":tmp_folder,
                         "mode": "rw"
                     },

vantage/util/__init__.py

@@ -115,6 +115,12 @@ def setup_logging(self):
         log.info("Succesfully loaded configuration from '%s'" % self.config_file)
         log.info("Logging to '%s'" % self.log_file)
         self.log = log
+    
+    def docker_temporary_volume_name(self, run_id):
+        return (
+            f"{constants.APPNAME}-{self.name}-{self.scope}"
+            f"-{run_id}-tmpvol"
+        )
 
     @property
     def docker_container_name(self):