Session size is now always correct as it is update on add/edit/remove annex

Adapted call to get_sessions_for to pass readonly=False as we update size when annex modified

Author: gbastien

src/imio/esign/events.py

@@ -10,7 +10,7 @@ def on_categorized_annex_updated(annex, event):
     if not old_values:
         return
 
-    sessions = get_sessions_for(event.parent.UID())
+    sessions = get_sessions_for(event.parent.UID(), readonly=False)
     if not sessions:
         return
 
@@ -24,7 +24,7 @@ def on_categorized_annex_updated(annex, event):
             break
     if update:
         annex_uid = annex.UID()
-        for session in sessions:
+        for session_id, session in sessions.items():
             # size
             size_diff = new_values['filesize'] - old_values['filesize']
             session['size'] += size_diff

src/imio/esign/tests/test_utils.py

@@ -30,6 +30,8 @@
 from plone.namedfile.file import NamedBlobFile
 from plone.namedfile.file import NamedBlobImage
 from zope.annotation import IAnnotations
+from zope.event import notify
+from zope.lifecycleevent import ObjectModifiedEvent
 
 import collective.iconifiedcategory
 import json
@@ -501,6 +503,7 @@ def test_add_files_already_exist_is_updated(self):
         # edit file, filename and content so size changed
         with open(os.path.join(os.path.dirname(__file__), "annex1.pdf"), "rb") as f:
             annex1.file = NamedBlobFile(data=f.read(), filename=u"new_annex1.pdf", contentType="application/pdf")
+        notify(ObjectModifiedEvent(annex1))
         sid, session = add_files_to_session(signers, (annex1_uid,))
         self.assertEqual(sid, 0)
         self.assertEqual(len(session["files"]), 2)

src/imio/esign/utils.py

@@ -93,11 +93,7 @@ def add_files_to_session(
             old_filename = path.splitext([fn for fn in session["files"]
                                           if fn['uid'] == uid][0]['filename'])[0]
             existing_files.remove(old_filename)
-            # session size will be updated when removing file from session
-            # so save it because it is already correct
-            saved_size = session["size"]
             remove_files_from_session([uid], remove_empty_session=False)
-            session["size"] = saved_size
 
         filename, ext = path.splitext(annex.file.filename or "no_filename.pdf")
         new_filename = get_correct_id(existing_files, filename)