Fix and optimization in on_categorized_annex_updated to avoid process if annex not really on a session

Author: gbastien

src/imio/esign/events.py

@@ -17,24 +17,34 @@ def on_categorized_annex_updated(annex, event):
     if not sessions:
         return
 
+    # make sure annex_uid is in a session
     annex_uid = annex.UID()
-    new_values = event.new_values
+    file_infos = []
+    for session_id in sessions:
+        file_info = get_file_info(session_id, annex_uid)
+        if file_info:
+            file_infos.append(file_info)
+    if not file_infos:
+        return
+
+    # here we are sure that annex is in a session, we need to update data
     # if something usefull changed, we will update the session
+    new_values = event.new_values
     update = False
     checked_keys = ['title', 'filesize', 'relative_url']
     for checked_key in checked_keys:
         if new_values[checked_key] != old_values[checked_key]:
             update = True
             break
     # check scan_id and filename
-    for session_id in sessions:
-        file_info = get_file_info(session_id, annex_uid)
-        if annex.scan_id != file_info['scan_id'] or \
-           annex.file.filename != file_info['filename']:
-            update = True
-            break
+    if update is False:
+        for file_info in file_infos:
+            if file_info and (annex.scan_id != file_info['scan_id'] or \
+               annex.file.filename != file_info['filename']):
+                update = True
+                break
 
-    if update:
+    if update is True:
         for session_id, session in sessions.items():
             # size
             size_diff = new_values['filesize'] - old_values['filesize']

src/imio/esign/tests/test_utils.py

@@ -518,6 +518,10 @@ def test_add_files_already_exist_is_updated(self):
         notify(ObjectModifiedEvent(annex1))
         self.assertEqual(session["files"][1]["filename"], "new_annex0-1.pdf")
         self.assertEqual(session["files"][1]["scan_id"], "012345600000002")
+        # edit annex out of any session
+        annex2_uid = self.uids[2]
+        annex2 = api.content.get(UID=annex2_uid)
+        notify(ObjectModifiedEvent(annex2))
         # just to check, remove annex0
         remove_files_from_session((annex0_uid,))
         self.assertEqual(session["size"], 6968)