Skip to content

Commit a10fc7b

Browse files
committed
Fix the activation script.
Do not export a VIRTUAL_ENV environment variable when activating the ODK native environment, as this can cause confusion with Python-style virtual environments.
1 parent 646008a commit a10fc7b

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

src/incatools/odk/activate.jinja2

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ deactivate() {
4040
export PS1
4141
unset _OLD_VIRTUAL_PS1
4242
fi
43-
unset VIRTUAL_ENV
44-
unset VIRTUAL_ENV_PROMPT
4543
unset ODK_RESOURCES_DIR
4644

4745
hash -r 2>/dev/null
@@ -53,26 +51,21 @@ deactivate() {
5351

5452
deactivate nondestructive
5553

56-
VIRTUAL_ENV={{target_dir}}
57-
export VIRTUAL_ENV
58-
5954
_OLD_VIRTUAL_PATH="$PATH"
60-
PATH="$VIRTUAL_ENV/bin:$PATH"
55+
PATH="{{target_dir}}/bin:$PATH"
6156
export PATH
6257

6358
if ! [ -x "${PYTHONHOME+_}" ]; then
6459
_OLD_VIRTUAL_PYTHONHOME="$PYTHONHOME"
6560
unset PYTHONHOME
6661
fi
6762

68-
VIRTUAL_ENV_PROMPT=$(basename "$VIRTUAL_ENV")
69-
export VIRTUAL_ENV_PROMPT
70-
7163
_OLD_VIRTUAL_PS1="${PS1-}"
72-
PS1="(${VIRTUAL_ENV_PROMPT}) ${PS1-}"
64+
PS1="({{target_dir.name}}) ${PS1-}"
7365
export PS1
7466

75-
ODK_RESOURCES_DIR="$VIRTUAL_ENV/resources"
67+
ODK_RESOURCES_DIR="{{target_dir}}/resources"
7668
export ODK_RESOURCES_DIR
7769

7870
hash -r 2>/dev/null || true
71+

0 commit comments

Comments
 (0)