Always use GitHub-CLI for public releases to GitHub.

This commit removes the `github_curl` and `github_python` methods of
pushing a release to GitHub – these should no longer be needed now that
GitHub-CLI is available.

The public_release ODK option should now be set to the name of the
hosting service for releases. For now, the only supported option is
`github` (which, in effect, is exactly as before). The older values
`github_curl` and `github_python` are silently transformed into
`github`.

This is a backport of INCATools/ontology-development-kit#1297, which
happened in the original repository after ODK-Core had been started.

Author: gouttegd

src/incatools/odk/model.py

@@ -1009,11 +1009,12 @@ class OntologyProject(JsonSchemaMixin):
     use_context: bool = False
     """Uses a context file to manage prefixes used across the project."""
 
-    public_release: str = "none"
-    """If true add targets to run automated releases.
+    public_release: Optional[str] = None
+    """Add supports for automatically publishing releases.
 
-    This is experimental. Current options: github_curl, github_python.
-    """
+    The value should be the name of the hosting service where the
+    releases should be pushed. Currently the only supported option is
+    'github'."""
 
     public_release_assets: Optional[List[str]] = None
     """Files to deploy as release assets.
@@ -1192,3 +1193,10 @@ def derive_fields(self) -> None:
             self.robot.obo_format_options += (
                 '--clean-obo "strict drop-untranslatable-axioms"'
             )
+
+        # Backwards compatibility support for deprecated 'public_release' settings
+        if (
+            self.public_release == "github_curl"
+            or self.public_release == "github_python"
+        ):
+            self.public_release = "github"

src/incatools/odk/templates/src/ontology/Makefile.jinja2

@@ -1503,69 +1503,35 @@ $(ONT)-basic.owl: $(EDIT_PREPROCESSED) $(OTHER_SRC) $(SIMPLESEED) $(KEEPRELATION
 explain_unsat: $(EDIT_PREPROCESSED) 
 	$(ROBOT) explain -i $< -M unsatisfiability --unsatisfiable random:10 --explanation $(TMPDIR)/[email protected]
 
-{%- if project.public_release != 'none'  %}
+{% if project.public_release == 'github' -%}
 # ----------------------------------------
-# GitHub release (HIGHLY experimental)
+# GitHub release
 # ----------------------------------------
 
-RELEASEFILES={% if project.public_release_assets is not none -%}{% for gha in project.public_release_assets %} {{ gha }}{% endfor -%}{% else -%}$(ASSETS){% endif %}
-TAGNAME=v$(TODAY)
-{% endif %}
-
-{% if project.public_release == 'github_curl'  %}
-USER=unknown
-GH_ASSETS = $(patsubst %, $(TMPDIR)/gh_release_asset_%.txt, $(RELEASEFILES))
-GITHUB_REPO={{ project.github_org }}/{{ project.repo }}
-
-$(TMPDIR)/release_get.txt: | $(TMPDIR)
-	curl -s https://api.github.com/repos/${GITHUB_REPO}/releases/tags/${TAGNAME} > $@
-
-$(TMPDIR)/release_op.txt: $(TMPDIR)/release_get.txt | $(TMPDIR)
-	$(eval RELEASEID=$(shell cat $(TMPDIR)/release_get.txt | jq '.id'))
-	if ! [ "$(RELEASEID)" -eq "$(RELEASEID)" ] ; then \
-		curl -s -X POST \
-			https://api.github.com/repos/${GITHUB_REPO}/releases \
-			-H 'Accept: */*' \
-			-H 'Content-Type: application/json' \
-			-u ${USER} \
-			-d '{ "tag_name": "${TAGNAME}", "target_commitish": "master", "name": "${TAGNAME}", "body": "Ontology release ${TODAY}", "draft": false, "prerelease": false }' > $@; \
-	else \
-		cp $< $@; \
-	fi;
-
-$(TMPDIR)/gh_release_id.txt: $(TMPDIR)/release_op.txt | $(TMPDIR)
-	echo $(shell cat $(TMPDIR)/release_op.txt | jq '.id') > $@;
-
-$(TMPDIR)/gh_release_asset_%.txt: $(TMPDIR)/gh_release_id.txt % | $(TMPDIR)
-	curl -X POST \
-		"https://uploads.github.com/repos/${GITHUB_REPO}/releases/$(shell cat $(TMPDIR)/gh_release_id.txt)/assets?name=$*&label=$*" \
-		--data-binary @$* \
-		-u ${USER} \
-		-H 'Accept: */*' \
-		-H 'Cache-Control: no-cache' \
-		-H 'Connection: keep-alive' \
-		-H 'Content-Type: application/octet-stream' > $@
-
-public_release: $(TMPDIR)/gh_release_id.txt $(GH_ASSETS) | $(TMPDIR)
-{% endif %}
-{%- if project.public_release == 'github_python'  %}
-GITHUB_RELEASE_PYTHON=make-release-assets.py
+GHVERSION = v$(VERSION)
 
 .PHONY: public_release
 public_release:
-	ls -alt $(ASSETS)
-	$(GITHUB_RELEASE_PYTHON) --release $(TAGNAME) $(RELEASEFILES)
-{% else  %}
+	@echo "Pushing public release $(GHVERSION)..."
+	@ls -alt $(RELEASE_ASSETS_AFTER_RELEASE)
+	@gh release create $(GHVERSION) \
+		           --title "$(VERSION) Release" \
+		           --generate-notes \
+		           $(RELEASE_ASSETS_AFTER_RELEASE)
 
-GHVERSION=v$(VERSION)
+{% else -%}
+# ----------------------------------------
+# Public release
+# ----------------------------------------
 
 .PHONY: public_release
 public_release:
-	@test $(GHVERSION)
-	ls -alt $(RELEASE_ASSETS_AFTER_RELEASE)
-	gh release create $(GHVERSION) --title "$(VERSION) Release" --draft $(RELEASE_ASSETS_AFTER_RELEASE) --generate-notes
+	@echo "ERROR: No release management system configured (or system unsupported)."
+	@echo "       Fix your configuration or override this target with a custom"
+	@echo "       public release workflow in {{ project.id }}.Makefile."
+	@false
 
-{%- endif %}
+{% endif -%}
 
 # ----------------------------------------
 # General Validation