Skip to content

Commit 1d0bfa5

Browse files
committed
Move Ammonite to ODKFull.
Ammonite is no longer used by any standard, ODK-generated workflow -- it was only used by the `make validate_idranges` workflow, which now uses a dedicated program. So we move Ammonite to the ODKFull image only, in line with the intended usage of ODKLite -- ODKLite should contain everything that is required by standard workflows, and nothing more.
1 parent 92008dc commit 1d0bfa5

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ For more detailed changes see:
1414
- New [ROBOT Version 1.9.6](https://github.com/ontodev/robot/releases/tag/v1.9.6). This came with a great number of updates and upgrades, see release notes.
1515
- J2cli, a command-line tool to process Jinja2 templates, has been replaced by [Jinjanator](https://github.com/kpfleming/jinjanator). If your custom workflows invoke the `j2` tool, you will need to update them to use `jinjanate` instead.
1616
- New program `dicer-cli` to manage the ID range file.
17+
- Ammonite, the Scala interpreter, is no longer provided in the ODKLite image. If you need Ammonite, you must now use the ODKFull image.
1718

1819
## New configuration options
1920

Dockerfile

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ ENV ODK_VERSION=$ODK_VERSION
1313
ENV JENA_VERSION=4.9.0
1414
ENV KGCL_JAVA_VERSION=0.5.0
1515
ENV SSSOM_JAVA_VERSION=1.0.0
16+
ENV AMMONITE_VERSION=2.5.9
1617

1718
# Avoid repeated downloads of script dependencies by mounting the local coursier cache:
1819
# docker run -v $HOME/.coursier/cache/v1:/tools/.coursier-cache ...
@@ -84,6 +85,12 @@ RUN test "x$TARGETARCH" = xamd64 && ( \
8485
RUN wget -nv http://archive.apache.org/dist/jena/binaries/apache-jena-$JENA_VERSION.tar.gz -O- | tar xzC /tools && \
8586
mv /tools/apache-jena-$JENA_VERSION /tools/apache-jena
8687

88+
# Install Ammonite
89+
RUN wget -nv https://github.com/lihaoyi/Ammonite/releases/download/$AMMONITE_VERSION/2.13-$AMMONITE_VERSION \
90+
-O /tools/amm && \
91+
chmod 755 /tools/amm && \
92+
java -cp /tools/amm ammonite.AmmoniteMain /dev/null
93+
8794
# Install SPARQLProg.
8895
RUN swipl -g "pack_install(sparqlprog, [interactive(false),global(true)])" -g halt
8996

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ test_odklite_programs:
3535
@./tests/test-program.sh DOSDP-TOOLS dosdp-tools -v
3636
@./tests/test-program.sh OWLTOOLS owltools --version
3737
@./tests/test-program.sh OORT ontology-release-runner --help
38-
@./tests/test-program.sh AMMONITE sh amm --help
3938
@./tests/test-program.sh JINJANATOR jinjanate --version
4039
@./tests/test-program.sh DICER-CLI dicer-cli --version
4140
@./tests/test-program.sh ODK odk.py
@@ -44,6 +43,7 @@ test_odkfull_programs: test_odklite_programs
4443
@./tests/test-program.sh KONCLUDE Konclude -h
4544
@./tests/test-program.sh SOUFFLE souffle --version
4645
@./tests/test-program.sh JENA jena
46+
@./tests/test-program.sh AMMONITE sh amm --help
4747
@./tests/test-program.sh SPARQL sparql --version
4848
@./tests/test-program.sh SPARQLPROG pl2sparql -g halt
4949
@./tests/test-program.sh OBO-DASHBOARD obodash --help

docker/odklite/Dockerfile

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ LABEL maintainer="obo-tools@googlegroups.com"
44
ENV ROBOT_VERSION=1.9.7
55
ENV DOSDP_VERSION=0.19.3
66
ENV OWLTOOLS_VERSION=2020-04-06
7-
ENV AMMONITE_VERSION=2.5.9
87
ENV RELATION_GRAPH=2.3.2
98
ENV DICER_VERSION=0.1.0
109

@@ -70,12 +69,6 @@ RUN wget -nv https://github.com/owlcollab/owltools/releases/download/$OWLTOOLS_V
7069
chmod +x /tools/ontology-release-runner && \
7170
chmod +x /tools/owltools-oort-all.jar
7271

73-
# Install Ammonite.
74-
RUN wget -nv https://github.com/lihaoyi/Ammonite/releases/download/$AMMONITE_VERSION/2.13-$AMMONITE_VERSION \
75-
-O /tools/amm && \
76-
chmod 755 /tools/amm && \
77-
java -cp /tools/amm ammonite.AmmoniteMain /dev/null
78-
7972
# Install relation-graph
8073
RUN wget -nv https://github.com/balhoff/relation-graph/releases/download/v$RELATION_GRAPH/relation-graph-cli-$RELATION_GRAPH.tgz && \
8174
tar -zxvf relation-graph-cli-$RELATION_GRAPH.tgz && \

0 commit comments

Comments
 (0)