Skip to content

Commit 5f9e32e

Browse files
authored
Merge pull request #793 from INCATools/use-prebuilt-konclude
Use a pre-built Konclude binary on arm64.
2 parents f037255 + e8fdd75 commit 5f9e32e

File tree

2 files changed

+10
-22
lines changed

2 files changed

+10
-22
lines changed

Dockerfile

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ RUN DEBIAN_FRONTEND="noninteractive" apt-get install -y --no-install-recommends
5151
COPY --from=obolibrary/odkbuild:latest /staging/full /
5252

5353
# Install Konclude.
54-
# On x86_64, we get it from a pre-built release; on arm64, we
55-
# have built it in the builder image, now we need to install
56-
# the run-time dependencies (Qt5).
54+
# On x86_64, we get it from a pre-built release from upstream; on arm64,
55+
# we use a custom pre-built binary to which we just need to add the
56+
# run-time dependencies (the binary is not statically linked).
5757
ARG TARGETARCH
5858
RUN test "x$TARGETARCH" = xamd64 && ( \
5959
wget -nv https://github.com/konclude/Konclude/releases/download/v0.7.0-1138/Konclude-v0.7.0-1138-Linux-x64-GCC-Static-Qt5.12.10.zip \
@@ -64,7 +64,13 @@ RUN test "x$TARGETARCH" = xamd64 && ( \
6464
rm Konclude.zip \
6565
) || ( \
6666
DEBIAN_FRONTEND="noninteractive" apt-get install -y --no-install-recommends \
67-
libqt5xml5 libqt5network5 libqt5concurrent5 \
67+
libqt5xml5 libqt5network5 libqt5concurrent5 && \
68+
wget -nv https://incenp.org/files/softs/konclude/0.7/Konclude-v0.7.0-1138-Linux-arm64-GCC.zip \
69+
-O /tools/Konclude.zip && \
70+
unzip Konclude.zip && \
71+
mv Konclude-v0.7.0-1138-Linux-arm64-GCC/Binaries/Konclude /tools/Konclude && \
72+
rm -rf Konclude-v0.7.0-1138-Linux-arm64-GCC && \
73+
rm Konclude.zip \
6874
)
6975

7076
# Install Jena.

docker/builder/Dockerfile

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -96,21 +96,3 @@ RUN wget -nv https://github.com/ontodev/rdftab.rs/archive/refs/tags/v$RDFTAB_VER
9696
install -D -m 755 target/release/rdftab /staging/full/usr/bin/rdftab && \
9797
cd /build && \
9898
rm -rf rdftab.rs-$RDFTAB_VERSION rdftab.tar.gz /root/.cargo
99-
100-
# Compile Konclude if we are not on x86_64
101-
# (building Konclude is time-consuming, so we avoid it
102-
# on x86_64 where a pre-compiled binary is available).
103-
ARG TARGETARCH
104-
RUN test "x$TARGETARCH" != xamd64 && (apt-get update && \
105-
DEBIAN_FRONTEND="noninteractive" apt-get install -y --no-install-recommends \
106-
qtbase5-dev qt5-qmake qtbase5-dev-tools wget && \
107-
wget -nv https://github.com/konclude/Konclude/archive/refs/tags/v0.7.0-1138.tar.gz \
108-
-O /build/Konclude-0.7.0.tar.gz && \
109-
tar xf Konclude-0.7.0.tar.gz && \
110-
cd Konclude-0.7.0-1138 && \
111-
qmake -r CONFIG+=release CONFIG-=debug CONFIG+=static QT-=gui KoncludeWithoutRedland.pro && \
112-
make && \
113-
install -D -m 755 Release/Konclude /staging/full/usr/bin/Konclude && \
114-
cd /build && \
115-
rm -rf Konclude-0.7.0-1138 Konclude-0.7.0.tar.gz \
116-
) || true

0 commit comments

Comments
 (0)