Skip to content

Commit 7d8310a

Browse files
authored
Merge pull request #1084 from INCATools/add-equal-signs-dockerfile
Adding = operator to ENV assignments
2 parents 3b8504b + 1261d20 commit 7d8310a

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

Dockerfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ ARG ODKLITE_TAG=latest
44
FROM obolibrary/odklite:${ODKLITE_TAG}
55
LABEL maintainer="[email protected]"
66

7-
ENV PATH "/tools/apache-jena/bin:/tools/sparqlprog/bin:$PATH"
7+
ENV PATH="/tools/apache-jena/bin:/tools/sparqlprog/bin:$PATH"
88

99
ARG ODK_VERSION 0.0.0
10-
ENV ODK_VERSION $ODK_VERSION
10+
ENV ODK_VERSION=$ODK_VERSION
1111

1212
# Software versions
1313
ENV JENA_VERSION=4.9.0
@@ -16,7 +16,7 @@ ENV SSSOM_JAVA_VERSION=0.7.7
1616

1717
# Avoid repeated downloads of script dependencies by mounting the local coursier cache:
1818
# docker run -v $HOME/.coursier/cache/v1:/tools/.coursier-cache ...
19-
ENV COURSIER_CACHE "/tools/.coursier-cache"
19+
ENV COURSIER_CACHE="/tools/.coursier-cache"
2020

2121
# Add NodeSource package repository (needed to get recent versions of Node)
2222
COPY thirdpartykeys/nodesource.gpg /usr/share/keyrings/nodesource.gpg
@@ -103,7 +103,7 @@ RUN chmod +x /tools/obodash && \
103103

104104
# Install relation-graph
105105
ENV RG=2.3.2
106-
ENV PATH "/tools/relation-graph/bin:$PATH"
106+
ENV PATH="/tools/relation-graph/bin:$PATH"
107107
RUN wget -nv https://github.com/balhoff/relation-graph/releases/download/v$RG/relation-graph-cli-$RG.tgz \
108108
&& tar -zxvf relation-graph-cli-$RG.tgz \
109109
&& mv relation-graph-cli-$RG /tools/relation-graph \

docker/robot/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ LABEL maintainer="[email protected]"
33

44
WORKDIR /tools
55

6-
ENV ROBOT v1.9.6
6+
ENV ROBOT=v1.9.6
77
ARG ROBOT_JAR=https://github.com/ontodev/robot/releases/download/$ROBOT/robot.jar
8-
ENV ROBOT_JAR ${ROBOT_JAR}
8+
ENV ROBOT_JAR=${ROBOT_JAR}
99

1010
RUN apt-get update &&\
1111
apt-get upgrade -y &&\
@@ -20,6 +20,6 @@ RUN curl -L $ROBOT_JAR -o /tools/robot.jar &&\
2020
chmod +x /tools/robot && \
2121
chmod +x /tools/robot.jar
2222

23-
ENV PATH "/tools/:$PATH"
23+
ENV PATH="/tools/:$PATH"
2424
RUN echo "Keep me in sync with obolibrary/odkfull!"
2525
CMD robot -h

0 commit comments

Comments
 (0)