Skip to content

Commit 1ee99d0

Browse files
MTN Exercise M4.01 target correction (#871)
1 parent 6035f91 commit 1ee99d0

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

notebooks/linear_models_ex_01.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"penguins = pd.read_csv(\"../datasets/penguins_regression.csv\")\n",
4444
"feature_name = \"Flipper Length (mm)\"\n",
4545
"target_name = \"Body Mass (g)\"\n",
46-
"data, target = penguins[[feature_name]], penguins[target_name]"
46+
"data, target = penguins[[feature_name]], penguins[[target_name]]"
4747
]
4848
},
4949
{

notebooks/linear_models_sol_01.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"penguins = pd.read_csv(\"../datasets/penguins_regression.csv\")\n",
4444
"feature_name = \"Flipper Length (mm)\"\n",
4545
"target_name = \"Body Mass (g)\"\n",
46-
"data, target = penguins[[feature_name]], penguins[target_name]"
46+
"data, target = penguins[[feature_name]], penguins[[target_name]]"
4747
]
4848
},
4949
{
@@ -152,7 +152,7 @@
152152
"def goodness_fit_measure(true_values, predictions):\n",
153153
" # we compute the error between the true values and the predictions of our\n",
154154
" # model\n",
155-
" errors = np.ravel(true_values) - np.ravel(predictions)\n",
155+
" errors = true_values - predictions\n",
156156
" # We have several possible strategies to reduce all errors to a single value.\n",
157157
" # Computing the mean error (sum divided by the number of element) might seem\n",
158158
" # like a good solution. However, we have negative errors that will misleadingly\n",

python_scripts/linear_models_ex_01.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
penguins = pd.read_csv("../datasets/penguins_regression.csv")
4141
feature_name = "Flipper Length (mm)"
4242
target_name = "Body Mass (g)"
43-
data, target = penguins[[feature_name]], penguins[target_name]
43+
data, target = penguins[[feature_name]], penguins[[target_name]]
4444

4545
# %% [markdown]
4646
# ### Model definition

python_scripts/linear_models_sol_01.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
penguins = pd.read_csv("../datasets/penguins_regression.csv")
3535
feature_name = "Flipper Length (mm)"
3636
target_name = "Body Mass (g)"
37-
data, target = penguins[[feature_name]], penguins[target_name]
37+
data, target = penguins[[feature_name]], penguins[[target_name]]
3838

3939
# %% [markdown]
4040
# ### Model definition
@@ -106,7 +106,7 @@ def linear_model_flipper_mass(
106106
def goodness_fit_measure(true_values, predictions):
107107
# we compute the error between the true values and the predictions of our
108108
# model
109-
errors = np.ravel(true_values) - np.ravel(predictions)
109+
errors = true_values - predictions
110110
# We have several possible strategies to reduce all errors to a single value.
111111
# Computing the mean error (sum divided by the number of element) might seem
112112
# like a good solution. However, we have negative errors that will misleadingly

0 commit comments

Comments
 (0)