Skip to content

Commit e86af07

Browse files
committed
#278: Fix plugin after merge
Disables the file list temporarily to enable functionality of the program again, fixes the sumCommit plugin to work with the new implementations
1 parent 4adbe87 commit e86af07

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

binocular-frontend-new/src/components/dashboard/dashboardItem/dashboardItem.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ const DashboardItem = memo(function DashboardItem(props: {
4242
const [poppedOut, setPoppedOut] = useState(false);
4343

4444
const authorLists = useSelector((state: RootState) => state.authors.authorLists);
45-
const fileLists = useSelector((state: RootState) => state.files.fileLists);
45+
//const fileLists = useSelector((state: RootState) => state.files.fileLists);
4646
const sprintList = useSelector((state: RootState) => state.sprints.sprintList);
4747
const avaliableDataPlugins = useSelector((state: RootState) => state.settings.database.dataPlugins);
4848

@@ -95,12 +95,12 @@ const DashboardItem = memo(function DashboardItem(props: {
9595
setAuthors(authorLists[props.item.dataPluginId]);
9696
}
9797
}, [authorLists, props.item.dataPluginId]);
98-
const [files, setFiles] = useState([]);
98+
/*const [files, setFiles] = useState([]);
9999
useEffect(() => {
100100
if (props.item.dataPluginId !== undefined) {
101101
setFiles(fileLists[props.item.dataPluginId]);
102102
}
103-
}, [fileLists, props.item.dataPluginId]);
103+
}, [fileLists, props.item.dataPluginId]); */
104104
const [settings, setSettings] = useState(plugin.defaultSettings);
105105

106106
/**
@@ -211,7 +211,7 @@ const DashboardItem = memo(function DashboardItem(props: {
211211
key={plugin.name}
212212
settings={settings}
213213
authorList={authors}
214-
fileList={files}
214+
//fileList={files}
215215
sprintList={sprintList}
216216
parameters={{
217217
parametersGeneral: ignoreGlobalParameters ? parametersGeneralLocal : parametersGeneralGlobal,
@@ -255,7 +255,7 @@ const DashboardItem = memo(function DashboardItem(props: {
255255
key={plugin.name}
256256
settings={settings}
257257
authorList={authors}
258-
fileList={files}
258+
//fileList={files}
259259
sprintList={sprintList}
260260
parameters={{
261261
parametersGeneral: ignoreGlobalParameters ? parametersGeneralLocal : parametersGeneralGlobal,

binocular-frontend-new/src/plugins/visualizationPlugins/simpleVisualizationPlugin/src/chart/chart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ function Chart<SettingsType extends DefaultSettings, DataType>(props: Properties
4040
const [chartWidth, setChartWidth] = useState(100);
4141
const [chartHeight, setChartHeight] = useState(100);
4242

43-
const ChartRenderer = props.dataName === 'sumCommits' ? ColumnChart : StackedAreaChart;
43+
const ChartRenderer = props.dataName?.toLowerCase() === 'sumcommits' ? ColumnChart : StackedAreaChart;
4444
type AreaOrBarChart = ChartData | BarChartData;
4545

4646
const [chartData, setChartData] = useState<AreaOrBarChart[]>([]);

binocular-frontend-new/src/plugins/visualizationPlugins/sumCommits/src/index.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,13 @@ import { convertToChartData } from './utilities/dataConverter.ts';
99
import { DataPluginCommit } from '../../../interfaces/dataPluginInterfaces/dataPluginCommits.ts';
1010

1111
const SumCommits: VisualizationPlugin<SettingsType, DataPluginCommit> = {
12-
name: 'Sum Commits',
12+
name: 'SumCommits',
1313
// ts-expect-error
1414
chartComponent: null,
1515
settingsComponent: Settings,
1616
helpComponent: Help,
1717
dataConverter: convertToChartData,
18+
dataConnectionName: 'commits',
1819
defaultSettings: { showMean: false, showOther: false },
1920
export: {
2021
getSVGData: getSVGData,

0 commit comments

Comments
 (0)