Skip to content

Commit d907839

Browse files
authored
Merge pull request #17 from Tony763/debug-eescheme_do
Feature: Print also debug output of eescheme_do when logger set to debug level
2 parents 6e639df + 209ecf2 commit d907839

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

kicad-diff.py

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@
5555
import time
5656

5757
# Exit error codes
58+
# Debugging
59+
VERB = None
5860
# Fixed values
5961
INTERNAL_ERROR = 1
6062
ARGS_ERROR = 2
@@ -271,12 +273,16 @@ def GenSCHImageDirect(file, file_hash, hash_dir, file_no_ext, layer_names, all):
271273
# Create the PDF, or use a cached version
272274
if not CheckOptions(name_ops, cur_sch_ops) or not isfile(name_pdf):
273275
logger.info('Plotting the schematic')
274-
cmd = ['eeschema_do', 'export', '--file_format', 'pdf', '--monochrome', '--no_frame', '--output_name', name_pdf]
276+
cmd = ['eeschema_do']
277+
if VERB:
278+
cmd.append(VERB)
279+
cmd.extend(['export', '--file_format', 'pdf', '--monochrome', '--no_frame', '--output_name', name_pdf])
275280
if all:
276281
cmd.append('--all_pages')
277282
cmd.extend([file, '.'])
278283
logger.debug('Executing: '+str(cmd))
279-
call(cmd)
284+
res = call(cmd)
285+
logger.debug(res)
280286
if not isfile(name_pdf):
281287
logger.error('Failed to plot %s' % name_pdf)
282288
exit(FAILED_TO_PLOT)
@@ -307,7 +313,10 @@ def GenSCHImageSVG(file, file_hash, hash_dir, file_no_ext, layer_names, kiri_mod
307313
svgs = glob(pattern_svgs)
308314
if ops_changed or not svgs:
309315
logger.info('Plotting the schematic')
310-
cmd = ['eeschema_do', 'export', '--file_format', 'svg', '--monochrome', '--all_pages']
316+
cmd = ['eeschema_do']
317+
if VERB:
318+
cmd.append(VERB)
319+
cmd.extend(['export', '--file_format', 'svg', '--monochrome', '--all_pages'])
311320
if not kiri_mode:
312321
cmd.append('--no_frame')
313322
cmd.extend([file, hash_dir])
@@ -382,6 +391,7 @@ def run_command(command):
382391
logger.debug('Executing: '+shlex.join(command))
383392
try:
384393
res = run(command, check=True, stdout=PIPE, stderr=STDOUT).stdout.decode()
394+
logger.debug(res)
385395
except CalledProcessError as e:
386396
res = ''
387397
logger.debug('Running {} returned {}'.format(e.cmd, e.returncode))
@@ -847,6 +857,7 @@ def get_layer(line):
847857
# Create a logger with the specified verbosity
848858
if args.verbose >= 2:
849859
log_level = logging.DEBUG
860+
VERB = "-" + ("v" * (args.verbose - 1))
850861
elif args.verbose == 1:
851862
log_level = logging.INFO
852863
else:

kicad-git-diff.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
# Create a logger with the specified verbosity
5252
if args.verbose >= 2:
5353
log_level = logging.DEBUG
54-
verb = '-vv'
54+
verb = "-" + ("v" * args.verbose)
5555
elif args.verbose == 1:
5656
log_level = logging.INFO
5757
verb = '-v'

0 commit comments

Comments
 (0)