Skip to content

Incorrect return code #41

@CThuleHansen

Description

@CThuleHansen

FmuContainer.cpp can only return true or false. However, in some cases FATAL occurs (e.g. https://github.com/INTO-CPS-Association/fmu-rabbitmq/blob/development/rabbitmq-fmu/src/FmuContainer.cpp#L723) but it is swallowed by

if (fmu != nullptr && fmu->step(currentCommunicationPoint, communicationStepSize)) {
return fmi2OK;
}
return fmi2Discard;
and reduced to a fmi2Discard, which is wrong.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions