Skip to content

Commit 6f6ea49

Browse files
committed
Rename Unknown -> Deferred
1 parent 8411b0e commit 6f6ea49

File tree

20 files changed

+427
-417
lines changed

20 files changed

+427
-417
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ The following result should be visible on the "z" topic:
1717
```
1818

1919
### Note:
20-
If you want to provide e.g., an Unknown value then it must be done with:
20+
If you want to provide e.g., a Deferred value then it must be done with:
2121
```json
2222
{
23-
"Unknown": null
23+
"Deferred": null
2424
}
2525
```
2626

examples/dynamic_lola/defer_default.lola

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
in x
33
in e
44
out z
5-
z = defer(default(e, "x")) // Similar to defer("x") if e is Unknown on first sample
5+
z = defer(default(e, "x")) // Similar to defer("x") if e is Deferred on first sample

examples/dynamic_lola/defer_recvs_update.lola

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ in x
33
in s
44
out z
55
// Receives a new property with an update inside it to ensure that
6-
// despite garbage collection we never receive unknown
6+
// despite garbage collection we never receive deferred
77
z = defer(s)

examples/dynamic_lola/eval_default.lola

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
in x
33
in e
44
out z
5-
z = eval(default(e, "x")) // On steps where e=Unknown, evaluate to eval("x")
5+
z = eval(default(e, "x")) // On steps where e=Deferred, evaluate to eval("x")

examples/dynamic_lola/guided_dup.lola

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@ S = x
1212
// Adaptation condition is "x == 3"
1313
c = x == 3
1414
// R is Rcond
15-
R = when(T) && (c || default(R[-1], false)) // Eventually, after T was not Unknown
15+
R = when(T) && (c || default(R[-1], false)) // Eventually, after T was not Deferred
1616
// When we haven't received a new spec T, and R is not true, yield from old spec
1717
v = if R then defer(T) else S

examples/dynamic_lola/overlap_dup.lola

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ c = x == 3
1515
// T with a default value (because if currently doesn't lazy eval)
1616
Td = default(defer(T), 0)
1717
// R is Rcond
18-
R = when(T) && (c || default(R[-1], false)) // Eventually, after T was not Unknown
18+
R = when(T) && (c || default(R[-1], false)) // Eventually, after T was not Deferred
1919
// When T is not provided, use S. When T is provided but R is not true, use S + T. When T and R use T.
2020
v = if !when(T) then S else if !R then S + Td else Td
2121
// v = if when(T) then if R then Td else S + Td else S

src/core/values.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ pub enum Value {
2424
Bool(bool),
2525
List(EcoVec<Value>),
2626
Map(BTreeMap<EcoString, Value>),
27-
Unknown,
27+
Deferred,
2828
Unit,
2929
}
3030

@@ -242,7 +242,7 @@ impl Display for Value {
242242
}
243243
write!(f, "}}")
244244
}
245-
Value::Unknown => write!(f, "unknown"),
245+
Value::Deferred => write!(f, "deferred"),
246246
Value::Unit => write!(f, "()"),
247247
}
248248
}
@@ -283,7 +283,7 @@ impl Serialize for Value {
283283
match self {
284284
Value::Unit => serializer.serialize_none(),
285285

286-
Value::Unknown => serializer.serialize_str("⊥"),
286+
Value::Deferred => serializer.serialize_str("⊥"),
287287

288288
Value::Bool(b) => serializer.serialize_bool(*b),
289289

@@ -312,7 +312,7 @@ impl Serialize for Value {
312312
}
313313

314314
impl<'de> Deserialize<'de> for Value {
315-
// Certain edge cases were not covered by derived Serialize, such as handling Unknown
315+
// Certain edge cases were not covered by derived Serialize, such as handling Deferred
316316
// symmetrically, hence manual impl
317317
fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
318318
where
@@ -353,15 +353,15 @@ impl<'de> Deserialize<'de> for Value {
353353

354354
fn visit_str<E>(self, v: &str) -> Result<Value, E> {
355355
if v == "⊥" {
356-
Ok(Value::Unknown)
356+
Ok(Value::Deferred)
357357
} else {
358358
Ok(Value::Str(v.into()))
359359
}
360360
}
361361

362362
fn visit_string<E>(self, v: String) -> Result<Value, E> {
363363
if v == "⊥" {
364-
Ok(Value::Unknown)
364+
Ok(Value::Deferred)
365365
} else {
366366
Ok(Value::Str(v.into()))
367367
}
@@ -619,8 +619,8 @@ mod tests {
619619
}
620620

621621
#[test]
622-
fn test_json_serialize_unknown() {
623-
let v = Value::Unknown;
622+
fn test_json_serialize_deferred() {
623+
let v = Value::Deferred;
624624
let json = to_string(&v).unwrap();
625625
assert_eq!(json, "\"\"");
626626
}
@@ -720,9 +720,9 @@ mod tests {
720720
}
721721

722722
#[test]
723-
fn test_json_bot_maps_to_unknown() {
723+
fn test_json_bot_maps_to_deferred() {
724724
let v = "\"\"";
725725
let json: Value = from_str(&v).unwrap();
726-
assert_eq!(json, Value::Unknown);
726+
assert_eq!(json, Value::Deferred);
727727
}
728728
}

src/io/file/input_provider.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ fn input_file_data_iter(
1818
Box::new((0..=*max_key).map(move |time| {
1919
data.get(&time)
2020
.and_then(|data_for_time| data_for_time.get(&key).cloned())
21-
.unwrap_or(Value::Unknown)
21+
.unwrap_or(Value::Deferred)
2222
}))
2323
} else {
2424
Box::new(std::iter::empty())

src/io/testing/manual_output_handler.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ mod tests {
311311

312312
// Define ordering of variants
313313
let variant_order = |value: &Value| match value {
314-
Unknown => 0,
314+
Deferred => 0,
315315
Unit => 1,
316316
Bool(_) => 2,
317317
Int(_) => 3,
@@ -340,7 +340,7 @@ mod tests {
340340
}
341341
(Str(a), Str(b)) => a.cmp(b),
342342
(List(a), List(b)) => a.cmp(b), // Vec<Value> implements Ord if Value does
343-
_ => Ordering::Equal, // Unit and Unknown are considered equal within their kind
343+
_ => Ordering::Equal, // Unit and Deferred are considered equal within their kind
344344
}
345345
}
346346
}

src/lang/dist_lang/ast.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ pub enum DistSExpr {
3737
Defer(Box<Self>),
3838
// Update between properties
3939
Update(Box<Self>, Box<Self>),
40-
// Default value for properties (replaces Unknown with an alternative
40+
// Default value for properties (replaces Deferred with an alternative
4141
// stream)
4242
Default(Box<Self>, Box<Self>),
43-
IsDefined(Box<Self>), // True when .0 is not Unknown
44-
When(Box<Self>), // Becomes true after the first time .0 is not Unknown
43+
IsDefined(Box<Self>), // True when .0 is not Deferred
44+
When(Box<Self>), // Becomes true after the first time .0 is not Deferred
4545

4646
// Unary expressions (refactor if more are added...)
4747
Not(Box<Self>),

0 commit comments

Comments
 (0)